Allow to manually specify spectral range for Cheby #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seba-car If you ever run into this problem again ;-) |
goerz
force-pushed
the
manual-specrange
branch
from
54d3ced to
19057f8
Compare
Passing `E_min` and `E_max` with `specrange_method=:auto` (default) or `specrange_method=:manual` to `propagate`/`init_prop` for `method=Cheby` are now taken as the lowest and highest possible eigenvalue of the dynamical generator, thus allowing to manually specify the spectral range for which to calculate the Chebychev coefficients.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #62 +/- ##
========================================
+ Coverage 88.7% 88.9% +0.3%
========================================
Files 28 28
Lines 1907 1910 +3
========================================
+ Hits 1690 1697 +7
+ Misses 217 213 -4 ☔ View full report in Codecov by Sentry. |
goerz
force-pushed
the
manual-specrange
branch
from
19057f8 to
cd07aa3
Compare
|
Great! Thanks @goerz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing
E_minandE_maxwithspecrange_method=:auto(default) orspecrange_method=:manualtopropagate/init_propformethod=Chebyare now taken as the lowest and highest possible eigenvalue of the dynamical generator, thus allowing to manually specify the spectral range for which to calculate the Chebychev coefficients.