Manually use [email protected] on windows with explicit artifact #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to implement the solution mentioned on discourse here.
It seems that the upstream Kaleido library is shifting towards becoming a python only solution that will not shipped a stripped down compiled version of chromium as a binary, but will assume the user has chrome/chromium installed on its system.
Due to this, it is likely that we'll never see new version of the original library that will fix windows issues and be compatible with our current Artifact based solution.
Luckily, it seems that reverting to 0.1 on Windows solves the issue (I have not found any missing functionality on Windows in 0.1, and looking at the changelog for 0.2.0 there doesn't seem to be any signficant change for us julia users).
This PR simply adds explicit artifacts pointing to the 0.1 version shipped with Kaleido_jll just on windows systems.
It also adds a flag that to specify whether to use the manually provided version 0.1 of kaleido. This flag defaults to
trueon Windows systems and if the installed version of Kaleido_jll is not already 0.1.I believe that with this change we could potentially solve a lot of hassle for windows users automatically, and it will still be possible for people facing some issues with this to manually set the flag to false before running
PlotlyKaleido.start().With this fix, it should be possible to solve the original problem raised on discourse.