Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towards v3.0 #101

Closed
8 of 9 tasks
dkarrasch opened this issue Aug 7, 2020 · 2 comments · Fixed by #114
Closed
8 of 9 tasks

Towards v3.0 #101

dkarrasch opened this issue Aug 7, 2020 · 2 comments · Fixed by #114

Comments

@dkarrasch
Copy link
Member

dkarrasch commented Aug 7, 2020

We have currently two PRs in the pipeline that are breaking and therefore require a major release. So I thought we should collect ideas on what to put in there to not have major release every month or so. Clearly, we will have

Furthermore, I'd suggest to include

  • Introduce specific show methods, add Base.parent overload #87 with the new show methods (I guess the only way to really get a feeling for whether it's good or not is to start using it and collect "annoyed" feedback, otherwise I feel this is too distant to form an opinion just by reviewing the PR)
  • a nice Documenter documentation, which then could nicely address Relation to other libraries #98 (That shouldn't be too hard: I'm planning to mainly cut our long README into more digestible pieces as a first approach.)

Anything else? Of course, if some hot PR comes in, there's nothing that stops us from merging it and releasing another v2.x. I'd hope to finish this some time in late August/early September. Any contributions/PRs/suggestions are more than welcome.

Have a good (rest of the) summer everyone!

EDIT:

  • I think we should relax the type of the output variable in the mul!s to AbstractVecOrMat. The following works perfectly fine with matrices in LinearAlgebra:
using LinearAlgebra
mul!(rand(5,1), rand(5,5), rand(5))

TODO:

@Jutho
Copy link
Collaborator

Jutho commented Aug 7, 2020

All for this proposal, I will also try to find some time to review current PRs, and contribute where possible.

@dkarrasch
Copy link
Member Author

Gentle bump. What remains to be done is to decide if we want the constructor LinearMap(::Number, m, n) for FillMaps (or whether this is too close to UniformScaling-like maps) and a potential overhaul. I should add that the package is now basically 100% tested, so we might have a performance-oriented overhaul after we release v3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants