Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory regressions in daily benchmark #18569

Closed
KristofferC opened this issue Sep 18, 2016 · 10 comments
Closed

Memory regressions in daily benchmark #18569

KristofferC opened this issue Sep 18, 2016 · 10 comments
Labels
performance Must go faster regression Regression in behavior compared to a previous version

Comments

@KristofferC
Copy link
Member

Putting it here so it doesn't get forgotten.

3a31155#commitcomment-19063411

https://github.com/JuliaCI/BaseBenchmarkReports/blob/c446686d038e02992f7b0a60490e04577069720f/daily_2016_9_17/report.md

Noticed by @Sacha0
@KristofferC KristofferC added performance Must go faster regression Regression in behavior compared to a previous version labels Sep 18, 2016
@TotalVerb TotalVerb mentioned this issue Sep 18, 2016
Merged
@TotalVerb
Copy link
Contributor

TotalVerb commented Sep 18, 2016 •
edited
Loading

The ["array","cat",("catnd",5)] regression seems to have been introduced by #18467 and has been fixed by #18572.

Local benchmarking has indicated that all other regressions are likely caused by a different PR.

@KristofferC
Copy link
Member Author

Anyone has an idea about this?

@tkelman
Copy link
Contributor

tkelman commented Sep 23, 2016

Did we trigger nanosoldier on all the intermediate commits to see which one it was?

@KristofferC
Copy link
Member Author

Commit range is ec3d29e...3a31155

@KristofferC
Copy link
Member Author

@jrevels is there anyway to run nanosoldier on two arbitrary commits?

@nalimilan
Copy link
Member

Looks like you should be able to do that by commenting on a specific commit, and giving the reference commit via vs. See https://github.com/JuliaCI/Nanosoldier.jl#comment-examples

@KristofferC
Copy link
Member Author

Yeah, just thought if I could do it here for example.

@KristofferC
Copy link
Member Author

f30c949#commitcomment-19082011 seems to suggest that up to that commit things are ok?

@TotalVerb
Copy link
Contributor

Has this been figured out yet?

tkelman referenced this issue Dec 28, 2016
@timholy
Merge pull request #18494 from JuliaLang/mb/newaxis
5896213 
Add support for views with arrays of CartesianIndex
tkelman referenced this issue Dec 28, 2016
@StefanKarpinski
Merge pull request #12563 from stevengj/maxnan
628d0e4 
max and min of NaN return NaN
@KristofferC
Copy link
Member Author

I couoldnt reproduce this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nalimilan @KristofferC @tkelman @TotalVerb