Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uint8sc deprecation incorrect? #375

Closed
DrTodd13 opened this issue Oct 1, 2015 · 2 comments
Closed

uint8sc deprecation incorrect? #375

DrTodd13 opened this issue Oct 1, 2015 · 2 comments

Comments

@DrTodd13
Copy link

DrTodd13 commented Oct 1, 2015

@deprecate uint8sc ufixed8sc

Should this be FixedPointNumbers.ufixed8 instead of ufixed8sc?
@lkuper
Copy link

lkuper commented Oct 23, 2015

@timholy @DrTodd13 The deprecation warning that Images.jl gives for uint8sc is a bit misleading. It should say Images.ufixed8sc, not just ufixed8sc. It looks like Images.ufixed8sc is defined in https://github.com/timholy/Images.jl/blob/master/src/map.jl .

(Edit: or Images.jl could just export ufixed8sc, as @rened has suggested.)

@timholy timholy mentioned this issue Jan 29, 2017
Merged
@timholy
Copy link
Member

timholy commented Jan 30, 2017

Closed by #577

@timholy timholy closed this as completed Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lkuper @timholy @DrTodd13