Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grayim asymmetrie with IO #368

Closed
SimonDanisch opened this issue Sep 26, 2015 · 6 comments
Closed

grayim asymmetrie with IO #368

SimonDanisch opened this issue Sep 26, 2015 · 6 comments

Comments

@SimonDanisch
Copy link
Member

Should grayim always return Array{Gray{T}} ?
imread always returns this for any grayscale image and I think these two should match, shouldn't they?

Best,
Simon
@timholy
Copy link
Member

timholy commented Sep 26, 2015

Seems reasonable to me.

@timholy
Copy link
Member

timholy commented Sep 26, 2015

Gray was a johnny-come-lately to the Colors world.

@SimonDanisch
Copy link
Member Author

Allright...this is already fixed on sd/fileio...
I think only SIF.jl and Imagine.jl are missing for a merge.
We could just leave them in Images.jl and just change the method signature?!

@timholy
Copy link
Member

timholy commented Sep 26, 2015

Maybe I'm not understanding correctly, but why is grayim even defined in fileio?

@SimonDanisch
Copy link
Member Author

oh I meant in my Image branch ;)

@timholy timholy mentioned this issue Jan 29, 2017
Merged
@timholy
Copy link
Member

timholy commented Jan 30, 2017

Closed by #577

@timholy timholy closed this as completed Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDanisch @timholy