Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write benchmarks #152

Closed
timholy opened this issue Jan 27, 2020 · 1 comment
Closed

Write benchmarks #152

timholy opened this issue Jan 27, 2020 · 1 comment
Labels
good first issue Would make a good contribution from new contributors

Comments

@timholy
Copy link
Member

timholy commented Jan 27, 2020 •
edited
Loading

We could use many more benchmarks in the benchmark folder. If you're a newcomer, why is this an important contribution? There are surely ways the performance of this package could be improved, and having benchmarks makes it much easier for the algorithm developers to test the consequences of their changes (#154 is one of many potential examples).
@timholy timholy added the good first issue Would make a good contribution from new contributors label Jan 27, 2020
This was referenced Jan 27, 2020
Open
Open
@timholy
Copy link
Member Author

timholy commented Mar 4, 2020

Closed by #158

@timholy timholy closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Would make a good contribution from new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timholy