-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump tiffimages version #66
Conversation
@sjkelly do you mind merging this when you get a chance? The CI failure appears unrelated. |
Hmm it looks like CI didn't run at all though... |
#68 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66 +/- ##
===========================================
+ Coverage 69.23% 94.93% +25.70%
===========================================
Files 1 1
Lines 26 79 +53
===========================================
+ Hits 18 75 +57
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. |
@@ -1,7 +1,7 @@ | |||
name = "ImageIO" | |||
uuid = "82e4d734-157c-48bb-816b-45c225c6df19" | |||
authors = ["Ian Butterworth"] | |||
version = "0.6.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly related to this PR, but the repo is missing a tag/release for 0.6.7 it seems...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, but TagBot isn't happy even though I updated it to latest config and refreshed the DOCUMENTER_KEY etc. so I had to make a manual release after the tag was made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going off tests passing, and TiffImages 0.10 being used in tests, this LGTM.
However, we claim to support a lot of older TiffImages versions. Maybe that's true but it highlights the general need to test lower compat bounds too
No description provided.