-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytical unit tests for Cylinder
and CylinderSurface
#162
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
test/combinations.jl
Outdated
z = p_cyl.z | ||
ρ^(-1) * (ρ + φ * u"m" + z) * u"A" | ||
end | ||
solution = let |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
solution = let | |
solution = let |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 181 181
=========================================
Hits 181 181 ☔ View full report in Codecov by Sentry. |
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (I didn't check the maths, but I assume the solution is correct if tests are successful). Thanks!
Changed
Cylinder
andCylinderSurface
to include analytical solutions.using CoordRefSystems
to@testsnippet Combinations
.CHANGELOG.md
.Continues progress on #67