-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use newly-supported KVector Unitful extension to simplify differential #114
Conversation
end | ||
|
||
# Extract the length units used by the CRS of a Geometry | ||
_units(::Meshes.Geometry{M, CRS}) where {M, CRS} = Unitful.unit(CoordRefSystems.lentype(CRS)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JuliaFormatter] reported by reviewdog 🐶
_units(::Meshes.Geometry{M, CRS}) where {M, CRS} = Unitful.unit(CoordRefSystems.lentype(CRS)) | |
function _units(::Meshes.Geometry{M, CRS}) where {M, CRS} | |
Unitful.unit(CoordRefSystems.lentype(CRS)) | |
end |
Just realized that you're depending on me for this PR, so I'll push 0.1.9 out for your convenience. |
Thanks! This one is in line behind a much heftier PR, so no worries on the release timing. To your credit, CliffordNumbers.jl turns one of our core functions into a borderline one-liner, which is much more elegant than the previous solution. 😄 |
Status
Need to rebase after completion of #122.
Changes
v0.1.9
Meshes.Vec
toUnitful.Quantity{KVector}
which now support unit-aware wedge products_units(::Meshes.Vec)