Check lengths of RegularInTime arguments?

[simsurace]

I wonder whether the RegularInTime constructor should error if the lengths of its arguments don't match:

TemporalGPs.jl/src/space_time/regular_in_time.jl

Lines 8 to 13 in 3c56beb

	struct RegularInTime{
	Tt, Tv, Tts<:AbstractVector{Tt}, Tvs<:AbstractVector{<:AbstractVector{Tv}},
	} <: AbstractVector{Tuple{Tt, Tv}}
	ts::Tts
	vs::Tvs
	end

[willtebbutt]

Good catch -- that would be ideal.

This kind of check should be shoved inside another function that is marked @non_differentiable so that it doesn't hit AD performance.

[simsurace]

Interesting... is the constructor function ever AD'd through? I would have thought that once the object has been constructed, the AD wouldn't be able to see the function that was called during constuction.

[willtebbutt]

That's true if you construct before passing the RegularInTime to the function being differentiated. I was thinking about what happens if you construct the RegularInTime inside the function that you're differentiating though.