A few missing shapes

[yakir12]

A few useful shapes that are missing:

• SemiAntidot: Semicircles that can do transmission and transparency
• SemiEllipses: Semicircles that are ellipse shaped
• SemiAntiEllipse: SemiEllipses that can do transmission and transparency
• Segments: so not just semicircular shapes but any segment of an arc.
• Other: in the future it might be cool to include chebyshev, polynomials, gaussians, etc to the mix.

All names are just placeholders, let me know what you'd prefer. Also, the fact that Semicircle mentions the abstract type, Circular, instead of the concrete type, Disk, is a touch confusing (but just a bit).

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Datseris]

SemiAntidot and SemiEllipse are simple, but the function will be costly. You have to look at the code for Antidot/Ellipse and Semicircle. You will see that it is not that hard to combine them, using facedir, but it will result in many if clauses: one if clauses for being in the correct facedir, one clause for being in or out, etc. But it is definitely not hard.

SemiAntiEllipse I don't know what this means and I can't understand why SemiEllipse by itself is not enough...

Segments = #145

Other : I don't know what this means either, you will have to explain it!

Also, the fact that Semicircle mentions the abstract type, Circular, instead of the concrete type, Disk, is a touch confusing (but just a bit).

It subtypes Circular not Disk. It would be wrong to write that it subtypes Disk (which is also impossible since Disk is concrete)

[yakir12]

SemiAntiEllipse is a SemiEllipse that allows for transmission and refraction, which if I understood correctly, Disk, Ellipse, Semicircle, and SemiEllipse do not.

[Datseris]

Ellipse allows raysplitting. (I mean the current supported raysplitting)

[Datseris]

That's why it is plotted with red color instead of green: https://juliadynamics.github.io/DynamicalBilliards.jl/latest/visualizing/#periodic-billiards

see also color conventions here: https://juliadynamics.github.io/DynamicalBilliards.jl/latest/visualizing/#color-conventions