New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing / with tangent denominator #665

Open

oxinabox opened this issue Feb 20, 2024 · 0 comments

Labels

breaking

Member

oxinabox commented Feb 20, 2024 •

edited

Loading

along the same lines as #643
We should not have e.g.

Base.:(/)(a, b::AbstractThunk) = a / unthunk(b) 
Base.:(/)(a::AbstractThunk, b::AbstractThunk) = unthunk(a) / unthunk(b)

We have a few of these

Since while it makes sense to divide a tangent by a scalar (its just scaling down) it does done make sense to divide a scalar by a tangent.

oxinabox added the breaking label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment