Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pendulum 3.0.0 breaks package #10

Open
sanieldalib opened this issue Jan 30, 2024 · 3 comments
Open

Pendulum 3.0.0 breaks package #10

sanieldalib opened this issue Jan 30, 2024 · 3 comments

Comments

@sanieldalib
Copy link

Hey there, first of all thank you so much for an amazing package. I've spent so long looking for something that handles recurring events well.

When installing via pip install iCal-library v3.0.0 of Pendulum gets installed. When attempting to use the package the following error is thrown:

ImportError: cannot import name 'Period' from 'pendulum' (/Users/dsalib/Developer/oasis/venv/lib/python3.9/site-packages/pendulum/__init__.py)

I resolved this by pinning to v2.1.1 of Pendulum. You may want to do the same, or upgrade to support Pendulum v3.

Cheers!

@Jorricks
Copy link
Owner

Jorricks commented Feb 4, 2024

Hey @sanieldalib,

First of all, you made my day. Thanks for the compliments and I am happy to hear I helped you out!
I will draft a new release with a pendulum<3.0.0 restriction for now, and once I have the time I will upgrade it to pendulum 3.0.0.

Cheers!

@Jorricks
Copy link
Owner

Jorricks commented Feb 4, 2024

I created a new release; 0.2.3. This should correctly pin the dependencies :).

I also proceeded to check what is needed to support Pendulum 3.0.0. Unfortunately, they dropped some functionality which allowed us to create custom timezones. This functionality is available in the CPython test suite, but simply copy-pasting doesn't feel right. Therefore I opened the following topic; https://discuss.python.org/t/making-custom-timezones-possible-using-the-standard-library/45008.
Let's see what that brings.

I will keep this issue open until we have support for Pendulum 3.0.

@venkatarun95
Copy link

This looks like a really useful package. I desperately want support for rrule

Unfortunately, now it seems like there is a need for pendulum version 3.0.0 since the older version depends on distutils that has been deprecated since python 3.10, so I am unable to install it. I am however able to install pendulum 3.0.0 separately

See https://stackoverflow.com/questions/77247893/modulenotfounderror-no-module-named-distutils-in-python-3-12 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants