error on build: "MongoInternals" is not exported by "meteor/mongo"

[alisnic]

This constant is actually exported by the meteor/mongo package

Sample code:

import { MongoInternals } from 'meteor/mongo';

async function runTransactionWithRetry<T>(asyncFunction: (session: ClientSession) => Promise<T>): Promise<T | null> {
  let result: T | null = null;

  await MongoInternals.defaultRemoteCollectionDriver().mongo.client.withSession(async session => {
    await session.withTransaction(async () => {
      result = await asyncFunction(session);
    });
  });

  return result;
}

my package versions:

    "meteor-vite": "^3.1.2",
    "vite": "^6.0.7

Meteor version 3.0.4

Vite config:

import react from '@vitejs/plugin-react';
import fs from 'fs';
import { meteor } from 'meteor-vite/plugin';
import path from 'path';
import { defineConfig } from 'vite';
import { nodePolyfills } from 'vite-plugin-node-polyfills';

export default defineConfig({
  resolve: {
    alias: {
      '@': path.resolve(__dirname)
    }
  },
  plugins: [
    nodePolyfills(),
    react({ fastRefresh: false }),
    meteor({
      clientEntry: 'imports/startup/client/index.ts',
      stubValidation: {
        warnOnly: true
      },
      meteorStubs: {
        debug: false
      }
    })
  ],
  optimizeDeps: {
    exclude: ['@meteor-vite/react-meteor-data', 'io-ts'],
    esbuildOptions: {
      plugins: [
        {
          name: 'esbuild-plugin-react-virtualized',
          setup({ onLoad }) {
            onLoad(
              {
                filter: /react-virtualized[/\\]dist[/\\]es[/\\]WindowScroller[/\\]utils[/\\]onScroll\.js$/
              },
              async ({ path }) => {
                const code = fs.readFileSync(path, 'utf8');
                const broken = `import { bpfrpt_proptype_WindowScroller } from "../WindowScroller.js";`;
                return { contents: code.replace(broken, '') };
              }
            );
          }
        }
      ]
    }
  }
});

The error does not happen when starting the server locally

[alisnic]

Here is a repo that reproduces the problem - run meteor build ../some/path to reproduce. The problem is in conditionally imported code under if (Meteor.isServer). Somehow meteor-vite tries to import Meteor package in server mode on the client https://github.com/alisnic/meteor3-tla-repro/tree/meteor-vite

export async function isoFunc() {
  if (Meteor.isServer) {
    const { runTransactionWithRetry } = await import('/server/internals.ts')
    runTransactionWithRetry()
  } else {
    console.log('client!');
  }
}

[JorgenVatle]

Oh, thanks for the heads up on this. 🙌

Meteor-Vite does not currently have full support for Meteor-specific conditional imports. I'm not sure if there's any good way of implementing this behavior due to the way Vite analyzes module dependencies. Refactoring to use Vite's suggested environment-specific conditionals should help indicate to Vite that the module shouldn't be imported on the client.

• https://vite.dev/guide/ssr.html#conditional-logic
• https://vite.dev/guide/env-and-mode.html#env-variables

export async function isoFunc() {
-  if (Meteor.isServer) {
+  if (import.meta.env.SSR) { 
    const { runTransactionWithRetry } = await import('/server/internals.ts')
    runTransactionWithRetry()
  } else {
    console.log('client!');
  }
}

We may be able to do a find and replace for conditionals like this, though I worry there may be a risk of unwanted/hard-to-debug behavior if it matches something it shouldn't. I'll definitely have a closer look at ways to handle this, at least for the Meteor runtime variables like isProduction and isClient.