Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lights: Concave shapes doesn't work #9

Closed
JonathSpirit opened this issue Oct 21, 2022 · 0 comments · Fixed by #18
Closed

lights: Concave shapes doesn't work #9

JonathSpirit opened this issue Oct 21, 2022 · 0 comments · Fixed by #18
Assignees
@JonathSpirit
Labels
accepted bug Something isn't working
Milestone
v0.9.2

Comments

@JonathSpirit
Copy link
Owner

image

The convex hull algorithm used to block light isn't ideal with concave objects.

Maybe a good solution is to use convex/slicing algorithm like : https://github.com/mjjq/ConvexDecomposition
@JonathSpirit JonathSpirit added bug Something isn't working help wanted Extra attention is needed accepted labels Oct 21, 2022
@JonathSpirit JonathSpirit added this to the v0.9.2 milestone Oct 21, 2022
@JonathSpirit JonathSpirit linked a pull request Oct 23, 2023 that will close this issue
Concave polygon #18
Merged
@JonathSpirit JonathSpirit removed the help wanted Extra attention is needed label Oct 24, 2023
@JonathSpirit JonathSpirit self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JonathSpirit JonathSpirit

Labels
accepted bug Something isn't working
Projects
None yet
Milestone
v0.9.2
Development

Successfully merging a pull request may close this issue.

Concave polygon JonathSpirit/FastEngine
1 participant
@JonathSpirit