Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runPluginVerifier doesn't resolve latest EAP versions (maybe due to caching) #848

Closed
ahus1 opened this issue Nov 28, 2021 · 3 comments
Closed
Assignees
Milestone

Comments

@ahus1
Copy link

ahus1 commented Nov 28, 2021

In my plugin's setup, I added 2021.3 to run the verifier against the latest EAP release.

Looking at my build logs, I found that it cached an old EAP version and never updated it (IC-213.3714.440 in my case).

As a workaround (or solution?) I now specify the EAP build using IC-213.5744.202 in the properties (see asciidoctor/asciidoctor-intellij-plugin@8c70059).

How should this be used, and how is it supposed to work regarding EAP versions?

@YannCebron
Copy link
Member

YannCebron commented Jan 5, 2022

from https://github.com/JetBrains/gradle-intellij-plugin/#plugin-verifier-dsl:
Check the available build versions on https://jb.gg/intellij-platform-builds-list

AFAIU to target EAP you must specify exact build number. OTOH this is not necessary after RC, after which there will be no binary changes until GA.

@ahus1
Copy link
Author

ahus1 commented Jan 5, 2022

Hi @YannCebron - I didn't need to specify the exact build number of EAP versions, It worked, and it downloaded the EAP version available at that time.

As it was caching the information, it then didn't update the download when new EAP versions became available, and eventually the real release was available. It still "seemed" to work, but used an old version.

That was confusing. I can now avoid it by always specifying the build number. Once I specify a release number of an EAP, my local cache is "polluted" with a previous download.

@hsz hsz added this to the next milestone Mar 25, 2022
@hsz hsz closed this as completed Mar 25, 2022
@rickclephas
Copy link

rickclephas commented Oct 19, 2023

I just noticed a cache issue with EAP versions as well.

Using the following configuration:

intellij {
    version = "233-EAP-SNAPSHOT"
    type = "IC"
}

tasks {
    patchPluginXml {
        sinceBuild = "233"
        untilBuild = "233.*"
    }

    runPluginVerifier {
        // Don't set the ideVersions, but let listProductsReleases provide them
    }
}

This results in the listProductsReleases generating the following listProductsReleases.txt:

IC-2023.3

As a result the plugin verifier will cache IC-2023.3 instead of e.g. IC-233.9102.97.
This is fixed once you manually specify the ideVersions with a full build number.

Wouldn't it make sense to output the build number instead of the build version for non-release builds?
Would be happy to create a PR if it does make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants