Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounding problem #31

Open
m1s5 opened this issue Nov 19, 2024 · 2 comments
Open

Rounding problem #31

m1s5 opened this issue Nov 19, 2024 · 2 comments

Comments

@m1s5
Copy link

m1s5 commented Nov 19, 2024

https://github.com/Jeiwan/uniswapv3-code/blob/419fd1dd2aabc0bdbfe326ed34cc641934e49210/test/UniswapV3Pool.t.sol#L643C58-L643C75

Is not it some kind of an issue worth fixing? I think it is intolerable to burn money like that. As far as i get it nobody would be able to get them.

@m1s5
Copy link
Author

m1s5 commented Nov 19, 2024

i think that if you have, say, 5 tokens and 2 participants the division should work like 2 | 3 and not 2 | 2 and 1 burned.

@m1s5
Copy link
Author

m1s5 commented Nov 19, 2024

and, moreover, if this kind of a kink will be mirrored(not sure it's possible), the pool will not be able to work of insufficient tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant