Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what-if: expose yaru-colors in appearance panel #132

Open
21 of 25 tasks
Muqtxdir opened this issue Jan 29, 2022 · 10 comments
Open
21 of 25 tasks

what-if: expose yaru-colors in appearance panel #132

Muqtxdir opened this issue Jan 29, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@Muqtxdir
Copy link
Collaborator

Muqtxdir commented Jan 29, 2022

hi,

after having discussions with @Jannomag. It seemed that it would benefit a lot of ubuntu users to integrate Yaru colors with what if PPA.

Note: This is only targeted toward people who use ubuntu-desktop

TO-DO:

  • review what colors to include and which to exclude to avoid conflicts.

    • Aqua
    • Blue
    • Green
    • Lavender
    • Pink
    • Red
    • Yellow
  • expose themes as accent-colors in Appearance panel.

    • Rename Window Colors to Style
    • Add HdyPreferencesGroup for Colors
    • Use GtkToggleButton for exposing the default and other 7 colors.
    • Make GtkFlowBoxChild and GtkToggleButton help in switching Style and Colors simultaneously.
    • Add new thumbnails for remaining 7 colors.
  • create separate what-if-21.10 branch for ubuntu 21.10

    • GTK-3.0
    • GTK-2.0
    • GTK-4.0
    • Icons
    • GNOME-Shell
    • upload to what if PPA.
  • add install instructions to README

other:

  • add install instructions.
  • backport to 20.04
  • port to 22.04

early demo:

2022-01-31.19-59-49.mp4

Fixes: #129, #124, #122, #120, #111

Thanks!

@Muqtxdir Muqtxdir self-assigned this Jan 29, 2022
@Muqtxdir Muqtxdir added the enhancement New feature or request label Jan 29, 2022
@Muqtxdir
Copy link
Collaborator Author

Muqtxdir commented Feb 1, 2022

Yaru-colors is now packaged for what -if PPA for ubuntu 21.10.

install:

sudo add-apt-repository ppa:muqtxdir-m/what-if
sudo apt update
sudo apt upgrade

uninstall:

sudo apt install ppa-purge && sudo ppa-purge ppa:muqtxdir-m/what-if

@Muqtxdir
Copy link
Collaborator Author

Muqtxdir commented Feb 1, 2022

hi @Mek101

could you update/build Yaru-Aqua, Yaru-Blue, Yaru-Green, Yaru-Lavender, Yaru-Pink, Yaru-Red, Yaru-Yellow from what-if-21.10 branch for the Flatpak themes?

@Mek101
Copy link

Mek101 commented Feb 1, 2022

Note: This is only targeted toward people who use ubuntu-desktop

?

Also, I would like to have a confirm by @Jannomag or somebody with push privileges, if possible

@Jannomag
Copy link
Owner

Jannomag commented Feb 1, 2022

Note: This is only targeted toward people who use ubuntu-desktop

?

Also, I would like to have a confirm by @Jannomag or somebody with push privileges, if possible

I can confirm whatever @Muqtxdir says...

Tbh, I stopped working on Yaru-Colors since the current changes on Ubuntu-Desktop and also Gnome will brake the limits of my knowledge.
@Muqtxdir is collaborator of this repo and he has my permission to do whatever he wants with this project.

Maybe in the future I will be back again, but no promises.

@Muqtxdir
Copy link
Collaborator Author

Muqtxdir commented Feb 2, 2022

Note: This is only targeted toward people who use ubuntu-desktop

?

Also, I would like to have a confirm by @Jannomag or somebody with push privileges, if possible

I decided to only target ubuntu-desktop, because it's the one I use and most of yaru-colors users are on. I can't make out time to test and build for all the colors provided by yaru-colors. So I mentioned Jan that I'd use around 7 other colors mentioned above to keep it specific for what if PPA and integrate it closely with GNOME-Shell (you wouldn't need user themes extension for changing GNOME Shell themes ) and gnome-control-center

If someone else is interested in covering all the yaru-colors and keeping it distribution agnostic, they can make PR for that : )

@Mek101
Copy link

Mek101 commented Feb 2, 2022

@Muqtxdir the tool I wrote to manage all the combinations only supports creating manifests from the releases. Could you make one?

@Muqtxdir
Copy link
Collaborator Author

Muqtxdir commented Feb 2, 2022

done, please take look at the releases page

@Mek101
Copy link

Mek101 commented Feb 3, 2022

Should be updated. Could you check if everything works for you?

@Muqtxdir
Copy link
Collaborator Author

Muqtxdir commented Feb 4, 2022

Should be updated. Could you check if everything works for you?

It looks like there are two branches for themes, why are there multiple branches?

   1) runtime/org.gtk.Gtk3theme.Yaru-Blue-dark/x86_64/stable           <----It looks you updated this 
   2) runtime/org.gtk.Gtk3theme.Yaru-Blue-dark/x86_64/3.22

@Mek101
Copy link

Mek101 commented Feb 4, 2022

I "deprecated" the 3.22 branch last year: flathub/org.gtk.Gtk3theme.Yaru-Amber@cd95b57
Mostly because I didn't really see the point of having multiple branches for what, at the end, is a Gtk 3 theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants