diff --git a/.github/workflows/commit-lint-prs.yml b/.github/workflows/commit-lint-prs.yml new file mode 100644 index 00000000..34677bbc --- /dev/null +++ b/.github/workflows/commit-lint-prs.yml @@ -0,0 +1,15 @@ +name: PR Conventional Commit Validation + +permissions: + pull-requests: read + +on: + pull_request: + types: [opened, synchronize, reopened, edited] + +jobs: + validate-pr-title: + runs-on: ubuntu-latest + steps: + - name: PR Conventional Commit Validation Against Commit Lint Config + - run: echo "${{ github.event.pull_request.title }}" | npx commitlint \ No newline at end of file diff --git a/.github/workflows/conventional-commit-prs.yml b/.github/workflows/conventional-commit-prs.yml deleted file mode 100644 index eedc0ae1..00000000 --- a/.github/workflows/conventional-commit-prs.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: PR Conventional Commit Validation - -permissions: - pull-requests: read - -on: - pull_request: - types: [opened, synchronize, reopened, edited] - -jobs: - validate-pr-title: - runs-on: ubuntu-latest - steps: - - name: PR Conventional Commit Validation - uses: ytanikin/pr-conventional-commits@1.4.0 - with: - task_types: '["feat","fix","docs","test","ci","refactor","perf","chore","revert"]' - add_label: 'false' \ No newline at end of file diff --git a/packages/terra-draw-maplibre-gl-adapter/README.md b/packages/terra-draw-maplibre-gl-adapter/README.md index 9dc44ac1..444a8f24 100644 --- a/packages/terra-draw-maplibre-gl-adapter/README.md +++ b/packages/terra-draw-maplibre-gl-adapter/README.md @@ -4,7 +4,7 @@ This package is for the [Terra Draw](https://www.github.com/JamesLMilner/terra-d ## Getting Started -For full getting started instructions for Terra Draw please read the [getting started guide in the GitHub repository](https://github.com/JamesLMilner/terra-draw/blob/main/guides/1.GETTING_STARTED.md). To get started with the MapboxGL adapter, please see the detailed [guide on adapters in the GitHub repository](https://github.com/JamesLMilner/terra-draw/blob/main/guides/3.ADAPTERS.md) to understand which are supported and how to get started with them. The guide has a specific section on the [TerraDrawMapLibreGLAdapter](https://github.com/JamesLMilner/terra-draw/blob/main/guides/3.ADAPTERS.md#maplibre). +For full getting started instructions for Terra Draw please read the [getting started guide in the GitHub repository](https://github.com/JamesLMilner/terra-draw/blob/main/guides/1.GETTING_STARTED.md). To get started with the MapLibre adapter, please see the detailed [guide on adapters in the GitHub repository](https://github.com/JamesLMilner/terra-draw/blob/main/guides/3.ADAPTERS.md) to understand which are supported and how to get started with them. The guide has a specific section on the [TerraDrawMapLibreGLAdapter](https://github.com/JamesLMilner/terra-draw/blob/main/guides/3.ADAPTERS.md#maplibre). #### Installation diff --git a/packages/terra-draw/src/modes/select/behaviors/drag-coordinate.behavior.ts b/packages/terra-draw/src/modes/select/behaviors/drag-coordinate.behavior.ts index cd048e8f..4e6ccb33 100644 --- a/packages/terra-draw/src/modes/select/behaviors/drag-coordinate.behavior.ts +++ b/packages/terra-draw/src/modes/select/behaviors/drag-coordinate.behavior.ts @@ -90,7 +90,7 @@ export class DragCoordinateBehavior extends TerraDrawModeBehavior { allowSelfIntersection: boolean, validateFeature?: Validation, ): boolean { - if (!this.draggedCoordinate.id) { + if (this.draggedCoordinate.id === null) { return false; } const index = this.draggedCoordinate.index;