Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timber.Tree.log() param documentation is incorrect. #206

Open
vaughandroid opened this issue Feb 1, 2017 · 1 comment
Open

Timber.Tree.log() param documentation is incorrect. #206

vaughandroid opened this issue Feb 1, 2017 · 1 comment

Comments

@vaughandroid
Copy link

The documentation of the message param indicates that it may be null when t is not null:

@param message Formatted log message. May be {@code null}, but then {@code t} will not be.

However, the implementation of Timber.Tree.prepareLog() will always append the stack trace to the message when t is not null. Hence, message will never be null.

@vaughandroid
Copy link
Author

Did a quick PR for this: #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant