Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero animation renders incorrectly as SVG #6

Closed
JakeWharton opened this issue Nov 20, 2020 · 3 comments · Fixed by #85
Closed

Hero animation renders incorrectly as SVG #6

JakeWharton opened this issue Nov 20, 2020 · 3 comments · Fixed by #85
Labels
blocked bug Something isn't working documentation Improvements or additions to documentation

Comments

@JakeWharton
Copy link
Owner

Loses a leading space somehow.

Filed marionebl/svg-term#19
@gowthamgts
Copy link

also, it doesn't work on github mobile. seeing only one frame.

@JakeWharton JakeWharton added bug Something isn't working documentation Improvements or additions to documentation labels May 5, 2021
@BigBadaboom
Copy link

This SVG has a slight rendering bug

Just in case you haven't already figured this out...

The SVG is rendering correctly. The rectangle is at X=0 and so is the text. So it must be a SVG generation bug.

@JakeWharton
Copy link
Owner Author

Right. The problem is the conversion to SVG from the asciinema format and not the rendering of the SVG by a browser.

@JakeWharton JakeWharton mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use agg to render gifs JakeWharton/mosaic
3 participants
@JakeWharton @BigBadaboom @gowthamgts