clang 19 #125
Closed
clang 19 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade to clang-19
Update to clang-19
Update to Clang-19
Dockerfile for static_analysis container (not for the GH Action):
- Fix case Docker build warning, FROM and AS are now both upper case
- Split ENVs up into per-item, I felt it was easier to read
- Split RUNs up into per-command (for the most part, there are still a
few multi-command RUNs), this helps with caching in the Docker
build process and I feel makes it more clear what is happening and
when, with cd replaced with WORKDIR so the Docker build process is
controlling where commands are run.
- Add --chmod to LLVM script COPY command with permissions so the
build can run the script and we no longer need a chmod command
prior to running the script
- RUN the script with ./ instead of bash -c because for some reason it
just will not work.
Updated the LLVM install file with the latest from https://apt.llvm.org
- The updated script added the option to specify all as an option to
install all LLVM packages as opposed to the base set of LLVM
packages, which added a set of extra packages behind a conditional
on the ALL flag (specified as all as a flag), with some additional
stuff for LLVM 14.
- Some quotes removed here and there.
- Updated the base set of LLVM packages to include clang-tidy, as the
updated base packages set did not include it, so this is different
compared to the JD version and the previous version.
- Updated script includes an updated LLVM_VERSION_PATTERNS that added
versions 19 and 20, with a placeholder for 21.
- Updated script added || true to the apt-key del AF4F7421 command.
- Updated script added a workaround for
llvm/llvm-project#62475
|
It looks like the Linter failure is a permissions issue on the repo with the Action. |
|
The Test Action failure is less clear. |
|
Tools updated, closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not address the issue in #124, but it updates the Action to use Clang 19.
Some of my changes are fairly opinionated and I wouldn't want you to take them as they are (unless they seem ok to you); you can check out the corresponding commits for some additional information.
Most of the static_analysis.dockerfile changes are based on my research about dockerfiles (since I'm relatively new to them) and helped me to understand, speed up, and follow the build process.
I have confirmed that these changes work here in my first run with the code from this branch in a pre-release version of the marketplace action I published, which uses a docker image built with the updated static_analysis.dockerfile here.
I really didn't have to change very much, but CMake takes a long time to compile so it took a bit to be able to really test it for real with my personal project, in which I'm using your Action for C++ analysis with clang-tidy and cppcheck.
I don't know how to do a PR to a new branch on your repo that doesn't exist yet, as I'm not sure these changes should go into master, but it was the only option.