-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hardcoded 127.0.0.1 in pre-build Docker images when used non-locally #570
Comments
😓As I said in other issues, there's no way to change the hardcoded reference in the Javascript bundle other than using a script to manually find and update the values which is not recommended since it might break some code and I am not going to implement it.
I am not closing any issues, I am just telling them what's the possible solution that they can use to get over it. The only possible thing I can do is implement an API that retrieves the environment variable from the server-side environment but I am not quite sure about the latency on that one. |
A string replace is one way of doing it. |
I already answered that in my response, |
I'm not sure what your experience with Docker is, but this is a non-standard way of using. |
I can surely open it, what would you recommend I should do instead? Changing the strings isn't a professional way either. |
This might be unrelated but I've been struggling find any information on how to change the port the front end is serving on from 3000 (conflicting with Grafana) on a non-docker environment. Is there a configuration for this or would the package code need to be changed? |
Closing issues about this does not make new issues not reappear.
There should be a way to check if the passed URL environment variables do not match the ones built into the bundle.
Do not close this issue until this is fixed.
The text was updated successfully, but these errors were encountered: