Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded 127.0.0.1 in pre-build Docker images when used non-locally #570

Open
realies opened this issue Jan 21, 2025 · 6 comments
Open
Labels
bug Something isn't working

Comments

@realies
Copy link
Contributor

realies commented Jan 21, 2025

Closing issues about this does not make new issues not reappear.

There should be a way to check if the passed URL environment variables do not match the ones built into the bundle.

Do not close this issue until this is fixed.

@realies realies added the bug Something isn't working label Jan 21, 2025
@ItzCrazyKns
Copy link
Owner

😓As I said in other issues, there's no way to change the hardcoded reference in the Javascript bundle other than using a script to manually find and update the values which is not recommended since it might break some code and I am not going to implement it.
Please consider reading this documentation to understand what is going on better.

Closing issues about this does not make new issues not reappear.

I am not closing any issues, I am just telling them what's the possible solution that they can use to get over it. The only possible thing I can do is implement an API that retrieves the environment variable from the server-side environment but I am not quite sure about the latency on that one.

@realies
Copy link
Contributor Author

realies commented Jan 21, 2025

A string replace is one way of doing it.
Another that comes to mind is to detect if the desired ENV variables are found in the bundle, if not - rebuild before starting.

@ItzCrazyKns
Copy link
Owner

A string replace is one way of doing it.

I already answered that in my response, there's no way to change the hardcoded reference in the Javascript bundle other than using a script to manually find and update the values which is not recommended since it might break some cod. If you're updating the variables you're already following the networking guide and it has proper steps for you to automatically build the images. Adding another script just to check is not something I think is really needed ATM. So, I will close this issue as well since I've already answered the question about 100 times in other issues so please check them if you have more doubts, feel free to re-open it.

@realies
Copy link
Contributor Author

realies commented Jan 21, 2025

I'm not sure what your experience with Docker is, but this is a non-standard way of using.
I (and it seems many others) don't want to maintain my own CI just to be able to use the official Docker images.
Why did you close this as completed when it is clearly not?

@ItzCrazyKns ItzCrazyKns reopened this Jan 21, 2025
@ItzCrazyKns
Copy link
Owner

I can surely open it, what would you recommend I should do instead? Changing the strings isn't a professional way either.

@shifusen329
Copy link

This might be unrelated but I've been struggling find any information on how to change the port the front end is serving on from 3000 (conflicting with Grafana) on a non-docker environment. Is there a configuration for this or would the package code need to be changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants