Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More eyeballs? #3

Open
mjordan opened this issue Dec 17, 2018 · 8 comments
Open

More eyeballs? #3

mjordan opened this issue Dec 17, 2018 · 8 comments

Comments

@mjordan
Copy link
Contributor

mjordan commented Dec 17, 2018

@rtilla1 and @rosiel, members of the Metadata IG will be interested in this tutorial. It would be good to get some more eyeballs on it!

@rosiel
Copy link
Member

rosiel commented Jan 1, 2019

Eyeballs engaged! I am in the process (rough) of creating some suggestions, which you can preview here: https://github.com/dannylamb/migrate_islandora_csv/compare/master...rosiel:scratchpad?expand=1 . I want to go revise some of my #fixme's and try to re-create your approachable style.

Did I get this right that this is a tutorial on using Migrate (i.e. required reading whether you're eventually using CSV or not)?

@mjordan
Copy link
Contributor Author

mjordan commented Jan 1, 2019

@rosiel Happy eyeballs New Year! Depending on when you built your CLAW vagrant, you might need to add --userid=1 when you run drush migrate:import commands. See #4.

@rosiel
Copy link
Member

rosiel commented Jan 3, 2019

Thanks @mjordan! I built it recently, but apparently I didn't update my claw playbook first. Oh geez.

Ok, a question for you and @dannylamb: can we rename the machine names of the migrations from file to something like [edited for oops] migrate_islandora_csv_file (etc)? It gets confusing trying to tell whether the string file refers to a migration, a column in the CSV, or something internal to Drupal.

  # Lookup the migrated file in the file migration.
  field_media_image:
    plugin: migration_lookup
    source: file 
    migration: file 
    no_stub: true

  # Lookup the migrated node in the node migration
  field_media_of:
    plugin: migration_lookup
    source: file 
    migration: node 
    no_stub: true

If so, should I make a separate ticket?

@mjordan
Copy link
Contributor Author

mjordan commented Jan 3, 2019

I think @dannylamb is more qualified to answer that than I am.

@dannylamb
Copy link
Contributor

@rosiel Yeah, I can rename those migrations. No need for a separate ticket.

@dannylamb
Copy link
Contributor

@rosiel Oh snap, I'm looking at your changes now. Why don't you toss a PR my way? 😄

@rosiel
Copy link
Member

rosiel commented Jan 8, 2019

First pass is merged. @rtilla1 is hopefully looking at it this week, and we're going to encourage the members of the MIG to take a gander too. Hopefully more eyeballs = better.

@mjordan
Copy link
Contributor Author

mjordan commented Jan 9, 2019

👁 👁 ++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants