Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbonite doesn't check current quest progress on quest givers #49

Closed
Rhendak opened this issue Sep 25, 2019 · 8 comments
Closed

Carbonite doesn't check current quest progress on quest givers #49

Rhendak opened this issue Sep 25, 2019 · 8 comments

Comments

@Rhendak
Copy link

Rhendak commented Sep 25, 2019

It seems that the quest givers on the map do not keep up to date with current quest progress. As can be seen in the screenshot below, I've already accepted the quests from this NPC, but they still show up on the map as acceptable quests.

image

In the screenshot below it seems like progress is not tracked and maybe showing future available quests, which are currently not available to me because I've not done the prequest? It also shows another quest which is not available at the NPC because I have already completed it.

image

@IrcDirk
Copy link
Owner

IrcDirk commented Sep 25, 2019

This option always shows all quest givers, not those that are available. It doesnt hide quest "!" when u complete. Only changes quest to green when it is completed. Thats all. It works as intended.

@Rhendak Rhendak changed the title Carbonite doesn't check current quest progress Carbonite doesn't check current quest progress on quest givers Sep 25, 2019
@Rhendak
Copy link
Author

Rhendak commented Sep 25, 2019

Didn't Carbonite used to load in a quest database and check how many quests were done by the player, then filter those quests out, causing them to not show on the map anymore?

When logging in or reloading it would say in chat:
"Marked < x amount > of quests as done."

@Kabulla
Copy link

Kabulla commented Sep 25, 2019

When logging in or reloading it would say in chat:
"Marked < x amount > of quests as done."

Which means, "marking them as green", if I understand correctly...

@IrcDirk
Copy link
Owner

IrcDirk commented Sep 25, 2019

Ok. Checked all and u need to check Get Completed Quest Information on Login in Quest Module then Quest Giver with All Completed and hand over quests will not show "!" on map.

@Rhendak
Copy link
Author

Rhendak commented Sep 25, 2019

Seems like I already had that option enabled, but still the same thing.

image

I turned in the quest (as can be seen in chat) then did a /reload (also seen in chat), it marked the completed quest as gray colored, but did not remove it from my (mini)map when I hover over the quest giver.
image

Also, side note: Is it worth creating 1 ticket that we can report all the missing quests in? Or should we just ignore the missing quests for now?

@IrcDirk
Copy link
Owner

IrcDirk commented Sep 25, 2019

Everything works fine u have to give up "Fuel for the Zapping" then "!" should hide. "Again With the Zapped Giants" doesnt show becouse i think use threshold to load quests, this will show when u level up.

I may have had the wrong colors:

  • white is quest that can be accepted
  • green is quest in progress
  • grey quest done and given up.

As to quest reporting i will not add them by hand, doesnt have time. Need to make some sort of webapp to let users fill/post the quest details.

@Rhendak
Copy link
Author

Rhendak commented Sep 25, 2019

Below are my threshold settings. I don't believe that that has anything to do with it. "Zapped Giants" and "Again With the Zapped Giants" just were not in the Carbonite database.

image

But what I really meant is that as can be seen in the chat, I've turned in "Zapped Giants", but it's still showing on the quest NPC.

This might have not been the best example, since the quest names are very similar. But they are seperate quests. "Zapped Giants" has been completed and should thus not be showing when hovering over the quest giver if I'm correct. Currently it's marked as grey which also means it's done, which I guess is fine too.

Strange thing is, only when ALL Quests from a specific NPC are completed, then the NPC quest giver disappears from the map. But before that stage is reached, completed quests are not filtered out. Only when all quests from the same quest giver have been completed, the quest giver will be filtered out entirely of the map.

@IrcDirk
Copy link
Owner

IrcDirk commented Sep 25, 2019

But what I really meant is that as can be seen in the chat, I've turned in "Zapped Giants", but it's still showing on the quest NPC.

Thats weird. I didnt had that on my side. Was questing today and i would pay attention if that would happen. That may be other addon. Disable all addons just leave Carb + modules and check again.

Strange thing is, only when ALL Quests from a specific NPC are completed, then the NPC quest giver disappears from the map. But before that stage is reached, completed quests are not filtered out. Only when all quests from the same quest giver have been completed, the quest giver will be filtered out entirely of the map.

Yes, thats how it is working since WoTLK, but maybe it should mimic more blizz like behaviour.

@IrcDirk IrcDirk closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants