Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mining nodes are not added to the database, with German client. #274

Closed
Termalator opened this issue Nov 12, 2022 · 27 comments
Closed

Comments

@Termalator
Copy link

I imported the GatherMate2_Data and they work fine, but nodes that are not in this database wan't be added.

I am using the german client.

@Termalator
Copy link
Author

Termalator commented Nov 12, 2022

sorry, now it worked, but i will look at it :)

Edit:
... nope it seems not to add the nodes, the one was only on a border and was already in the database.

@IrcDirk
Copy link
Owner

IrcDirk commented Nov 14, 2022

Need to check it. U sure that some other node that was already added was not in the radius?

@Termalator
Copy link
Author

I am not sure if it was already there because it was on the border of two zones (appearing disappearing area). The other nodes where in the middle of Wintergrasp so i am sure that it should be added but it wasn't.

@IrcDirk
Copy link
Owner

IrcDirk commented Nov 14, 2022

Ok, thanks... ill check that.

@Warbringer75
Copy link

i am having the issue too wit no gather showing up on the carbonite, also i am getting missing info when doing quest or dungeons, would dowb loading the gather addon help this nod issue or just the lib for it?

@IrcDirk
Copy link
Owner

IrcDirk commented Dec 6, 2022

@Warbringer75 Thats not the same issue. U need to import gathering nodes first. Try reading this issue => #162

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 8, 2023

@Termalator Sorry just checked and it records the nodes.

@Termalator
Copy link
Author

I noticed it in Wintergrasp on some points and it still wan´t record this nodes. Maybe it is an issue with the German localization?

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 8, 2023

Weird but maybe its cause of other client language... cant test it...

@Termalator
Copy link
Author

is there a trigger that i can print out if new node is found? then i can test it here.

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 9, 2023

Try here:

elseif Nx:IsGathering(arg2) == L["Mining"] then

@Termalator
Copy link
Author

hmm i added two lines with printouts :
(line 1135 ff)
`function Nx:OnUnit_spellcast_sent (event, arg1, arg2, arg3, arg4)

print(Nx:IsGathering(arg2))
if arg1 == "player" then
	local Nx = Nx
	if Nx:IsGathering(arg2) == "Herb Gathering" then
		Nx.GatherTarget = Nx.TooltipLastText

		if Nx.db.profile.Debug.DBGather then
			Nx.prt (L["Gather"] .. ": %s %s", arg2, Nx.GatherTarget or "nil")
		end

		if Nx.GatherTarget then
			Nx.UEvents:AddHerb (Nx.GatherTarget)
			Nx.GatherTarget = nil
		end

	elseif Nx:IsGathering(arg2) == L["Mining"] then
	    print("Mining node")
		Nx.GatherTarget = Nx.TooltipLastText`

when i was on a German client nothing happened. On English client everything worked as expected.

@Termalator
Copy link
Author

By the way i deleted all nodes so all nodes are "new"

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 9, 2023

Try dumping all arguments on German client, just after this:

function Nx:OnUnit_spellcast_sent (event, arg1, arg2, arg3, arg4)

And send me the dump here :)

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 9, 2023

Ohhh ... and u are mining or herbing?

@Termalator
Copy link
Author

just to check if the event is firing up? ok i will do so :)

@Termalator
Copy link
Author

mining at this time

@Termalator
Copy link
Author

i added print("arg1:" .. arg1 .. " arg2:" .. arg2 .. " arg3:" .. arg3 .. " arg4:" .. arg4) at line 1136 and that is the result:
arg1:player arg2:Titanvorkommen arg3:Cast-3-4460-571-48-50310-0000BC329F arg4:50310

@IrcDirk
Copy link
Owner

IrcDirk commented Jan 9, 2023

Yeah... seams there is no Titanvorkommen in Carbonite\Locales\deDE\HarvestNodes.lua

If u want u can check all those HarvestNodes for proper translation :) And send me the corrected one.

@Termalator
Copy link
Author

i was looking at this too :)

@Termalator
Copy link
Author

i will do so :)

@Termalator
Copy link
Author

Wowhead seems to have correct translations, i will check them and post it here :)

@Termalator
Copy link
Author

Termalator commented Jan 9, 2023

The herbs are looking good so far, but i will observe that.
Here are the corrected mines:
-- Mines
L["Adamantite Deposit"] = "Adamantitablagerung"
L["Ancient Gem Vein"] = "Uraltes Edelsteinvorkommen"
L["Blackrock Deposit"] = "Schwarzfelsvorkommen"
L["Cobalt Deposit"] = "Kobaltablagerung"
L["Copper Vein"] = "Kupfervorkommen"
L["Dark Iron Deposit"] = "Dunkeleisenablagerung"
L["Elementium Vein"] = "Elementiumader"
L["Fel Iron Deposit"] = "Teufelseisenvorkommen"
L["Ghost Iron Deposit"] = "Geistereisenvorkommen"
L["Gold Vein"] = "Goldvorkommen"
L["Incendicite Mineral Vein"] = "Pyrophormineralvorkommen"
L["Indurium Mineral Vein"] = "Induriummineralvorkommen"
L["Iron Deposit"] = "Eisenvorkommen"
L["Khorium Vein"] = "Khoriumvorkommen"
L["Kyparite Deposit"] = "Kyparitvorkommen"
L["Large Obsidian Chunk"] = "Gro\195\159er Obsidianbrocken"
L["Lesser Bloodstone Deposit"] = "Geringe Blutsteinablagerung"
L["Mithril Deposit"] = "Mithrilablagerung"
L["Nethercite Deposit"] = "Netheritablagerung"
L["Obsidium Deposit"] = "Obsidiumvorkommen"
L["Pyrite Deposit"] = "Pyritvorkommen"
L["Rich Adamantite Deposit"] = "Reiche Adamantitablagerung"
L["Rich Blackrock Deposit"] = "Reiches Schwarzfelsvorkommen"
L["Rich Cobalt Deposit"] = "Reiche Kobaltablagerung"
L["Rich Elementium Vein"] = "Reiche Elementiumader"
L["Rich Ghost Iron Deposit"] = "Reiches Geistereisenvorkommen"
L["Rich Kyparite Deposit"] = "Reiches Kyparitvorkommen"
L["Rich Obsidium Deposit"] = "Reiches Obsidiumvorkommen"
L["Rich Pyrite Deposit"] = "Reiches Pyritvorkommen"
L["Rich Saronite Deposit"] = "Reiche Saronitablagerung"
L["Rich Thorium Vein"] = "Reiches Thoriumvorkommen"
L["Rich Trillium Vein"] = "Reiche Trilliumader"
L["Rich True Iron Deposit"] = "Reiches Echteisenvorkommen"
L["Saronite Deposit"] = "Saronitablagerung"
L["Silver Vein"] = "Silbervorkommen"
L["Small Obsidian Chunk"] = "Kleiner Obsidianbrocken"
L["Small Thorium Vein"] = "Kleines Thoriumvorkommen"
L["Smoldering True Iron Deposit"] = "Qualmendes Echteisenvorkommen"
L["Thorium Vein"] = "Thoriumvorkommen" -- Used for Ooze covered even tho it's not a real node
L["Tin Vein"] = "Zinnvorkommen"
L["Titanium Vein"] = "Titanvorkommen"
L["Trillium Vein"] = "Trilliumader"
L["True Iron Deposit"] = "Echteisenvorkommen"
L["Truesilver Deposit"] = "Echtsilberablagerung"
--Legion Mines
L["Felslate Deposit"] = "Teufelsschiefervorkommen"
L["Felslate Seam"] = "Teufelsschieferfl\195\182z"
L["Living Felslate"] = "Lebender Teufelsschiefer"
L["Leystone Deposit"] = "Leysteinvorkommen"
L["Leystone Seam"] = "Leysteinfl\195\182z"
L["Living Leystone"] = "Lebender Leystein"
L["Infernal Brimstone"] = "Infernoschwefel"
-- 7.3 change
L["Empyrium Deposit"] = "Empyriumvorkommen"
L["Rich Empyrium Deposit"] = "Reiches Empyriumvorkommen"
L["Empyrium Seam"] = "Empyriumflöz"

@Termalator
Copy link
Author

i think the German names changed at some time.

@Termalator
Copy link
Author

seems to work now :)

@Termalator Termalator changed the title New mining nodes are not added to the database. New mining nodes are not added to the database, with German client. Jan 9, 2023
@Termalator
Copy link
Author

found one herb that was wrong :
-- L["Talandra's Rose"] = "Talandra's Rose"
++ L["Talandra's Rose"] = "Talandras Rose"

IrcDirk added a commit that referenced this issue Jan 9, 2023
@Termalator
Copy link
Author

Thank you, looks good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants