Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Voted on by me not showing past votes #2839

Open
MadOrkestra opened this issue Jan 30, 2025 · 7 comments
Open

🐛 Voted on by me not showing past votes #2839

MadOrkestra opened this issue Jan 30, 2025 · 7 comments
Labels
🐛 Bug Something isn't working ❓Unknown area

Comments

@MadOrkestra
Copy link

Area

Not sure

Domain

gov.tools

Which wallet were you using?

Eternl 1.12.21

Context

The "Voted on by me" tab does not show past votes.

Image

Voting tx: https://cardanoscan.io/transaction/75b13e1f54e3e55043b8bedfd7605c38d4cd00533f0a9e40ff61c1955187832f?tab=summary

Steps to reproduce

  1. Connect wallet
  2. Navigate to Governance Actions -> Live Voting -> Voted on by me
  3. No past votes are shown

Actual behavior

  1. Connect wallet
  2. Navigate to Governance Actions -> Live Voting -> Voted on by me
  3. No past votes are shown

Expected behavior

  1. Connect wallet
  2. Navigate to Governance Actions -> Live Voting -> Voted on by me
  3. Display past votes
@MSzalowski
Copy link
Contributor

Similar issue: #2839

@MadOrkestra
Copy link
Author

MadOrkestra commented Feb 1, 2025

@MSzalowski #2839 is this one ;)

@Ryun1 seems to be only affecting older votes btw, my vote on the Constitution proposal shows up correctly.

@MSzalowski
Copy link
Contributor

GovTool doesn't show ratified, enacted or expired GAs.
@Ryun1 Maybe it would be a good idea to show past votes as well?

@MadOrkestra
Copy link
Author

MadOrkestra commented Feb 1, 2025

Oh, I see. I expected a tab that says "Voted on by me" to display all my votes. Should probably be called "Current votes" or "Recent votes" then?

@Ryun1
Copy link
Member

Ryun1 commented Feb 3, 2025

@Ryun1 Maybe it would be a good idea to show past votes as well?

Yeah definitely, it is very confusing that these disappear from "Voted on" tab
Would this be very difficult to change?

longer term I believe this information will be reflected via the Outcomes pillar from Lido

@bosko-m
Copy link
Contributor

bosko-m commented Feb 3, 2025

@Ryun1 is correct on longer term.
Any copy change is simple. :)
Menu item is called Live Voting which kind of implies it relates to the live, current governance action. If we are to change copy, I would go with changing the copy of the menu item, which is going to include outcomes in the future anyway so Live Voting wouldnt apply anyway. Simple Voting instead of Live Voting would suffice I think.
What do you think guys?

@Ryun1
Copy link
Member

Ryun1 commented Feb 4, 2025

also raised here #2829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working ❓Unknown area
Projects
Status: No status
Status: No status
Development

No branches or pull requests

4 participants