Update Video_Clicks_and_click_tracking-Inline-test.xml #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A1exKH
suggested changes
May 1, 2024
There was a problem hiding this comment.
In PR title I can see:
"Update Video_Clicks_and_click_tracking-Inline-test.xml"
but real code changes contain only the next:
"http" -> "https"
@patmmccann, could you explain the idea of this PR, please?
|
The goal of this pr is that the examples pass checks in systems that validate all urls are secure (many modern ad systems do this now) Secure websites cannot show an insecure vast |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quality of life change on the schema location