Required parameter $params follows optional parameter $type in file /vendor/instamojo/instamojo-php/src/Instamojo.php on line 193

[rajuaryan21]

PHP Version: 8.0.9

is there any support for php 8.0?

As per the php 8.0 specification, the required parameter should come first and optional parameters should follow required parameters.

Can you guys please fix this?

[rajuaryan21]

So, insted of

static function init($type='app', $params, $test=false)
{
self::validateTypeParams($type, $params);
self::$authType = $type;
self::$clientId = $params['client_id'];
self::$clientSecret = $params['client_secret'];
self::$username = isset($params['username']) ? $params['username'] : '';
self::$password = isset($params['password']) ? $params['password'] : '';
self::$baseUrl = Instamojo::PRODUCTION_BASE_URL;
self::$scope = isset($params['scope']) ? $params['scope'] : null;
...
...

We can have this

static function init($params, $type='app', $test=false)
{
self::validateTypeParams($type, $params);
self::$authType = $type;
self::$clientId = $params['client_id'];
self::$clientSecret = $params['client_secret'];
self::$username = isset($params['username']) ? $params['username'] : '';
self::$password = isset($params['password']) ? $params['password'] : '';
self::$baseUrl = Instamojo::PRODUCTION_BASE_URL;
self::$scope = isset($params['scope']) ? $params['scope'] : null;

....
....

[rajuaryan21]

I see a bunch of other related errors in php 8 with this repository. Any plan to support already rolling php 8 version in the market?