feat: MykSuite chip #1421
Merged
feat: MykSuite chip #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
changed the base branch from
master
to
converstion-quota-dropbox-view
adrien-coye
force-pushed
the
converstion-quota-dropbox-view-chip
branch
from
0d31caa to
4de4641
Compare
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/NewFolder/NewFolderTypeTableViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/NewFolder/NewFolderTypeTableViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/Files/Rights and Share/ShareAndRightsViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 5, 2025
kDrive/UI/Controller/Files/File List/FileListViewController.swift
Outdated
Show resolved
Hide resolved
adrien-coye
force-pushed
the
converstion-quota-dropbox-view
branch
from
4350f73 to
951b6ae
Compare
adrien-coye
commented
Feb 10, 2025
kDrive/UI/View/Files/FileDetail/ShareLink/ShareLinkTableViewCell.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 10, 2025
kDrive/UI/View/Files/FileDetail/ShareLink/ShareLinkTableViewCell.swift
Outdated
Show resolved
Hide resolved
adrien-coye
commented
Feb 10, 2025
adrien-coye
commented
Feb 10, 2025
adrien-coye
commented
Feb 10, 2025
kDrive/UI/View/Files/FileDetail/ShareLink/ShareLinkTableViewCell.swift
Outdated
Show resolved
Hide resolved
adrien-coye
force-pushed
the
converstion-quota-dropbox-view-chip
branch
from
0dcc54f to
08faf5b
Compare
adrien-coye
commented
Feb 11, 2025
adrien-coye
force-pushed
the
converstion-quota-dropbox-view-chip
branch
from
af4d852 to
a9271d8
Compare
adrien-coye
force-pushed
the
converstion-quota-dropbox-view-chip
branch
from
a9271d8 to
53592e8
Compare
adrien-coye
force-pushed
the
converstion-quota-dropbox-view-chip
branch
from
c39b8ed to
bbcfce9
Compare
…dropbox-view-chip
PhilippeWeidmann
requested changes
Feb 12, 2025
kDrive/Resources/Assets.xcassets/Colors/binColor.colorset/Contents.json
Outdated
Show resolved
Hide resolved
kDrive/Resources/Assets.xcassets/Colors/trashColor.colorset/Contents.json
Outdated
Show resolved
Hide resolved
PhilippeWeidmann
approved these changes
Feb 12, 2025
* feat(FloatingPanelActionCollectionViewCell): Chip capability * feat: Enable chip for convertToDropbox action
* feat(MenuViewController): Hide upgrade cell that shows up on top of menu * feat(ShareLinkSettingsViewController): Present upsale sheet instead of store * feat(FileActionsFloatingPanelViewController): Present upsale sheet instead of store * feat(HomeViewController): Present upsale sheet instead of store * feat(NewFolderTypeTableViewController): Present upsale sheet instead of store * feat(FileActionsHelper): Present upsale sheet instead of store
|
adrien-coye
added a commit
that referenced
this pull request
Feb 14, 2025
* feat: Present a sample SwiftUI View * feat: Force ios-core-ui to mykSuite branch * feat: Tuist project setup with external feature module * chore: Bump coreUI * feat(MyKSuiteFloatingPanelBridgeController): Display SwiftUI code in container view * feat(MyKSuiteFloatingPanelBridgeController): Adjusted margins * feat(MyKSuiteFloatingPanelBridgeController): New kDrive dedicated assets * feat(Drive): Quota is now non nullable as discussed with backend * feat: Bump UI with latest API * feat(AppRouter): New explicit method presentUpSaleSheet * chore(MyKSuiteFloatingPanelBridgeController): Clean code * fix(AppRouter): Animate presentUpSaleSheet method * fix(AppRouter): Animate MyKSuiteFloatingPanelBridgeController prensentation * chore: Switched to ios-features * fix(MCKRouter): Updated test mock * fix(ios-features): Allow the project to build again with the new linked library * chore(AppRouter): Removed iOS 15 conditional code * chore(MyKSuiteFloatingPanelBridgeController): Removed iOS 15 conditional code * fix(Package.swift): Added InfomaniakDI as a Framework to guarantee only one exists at any point * feat: Trying to bridge a SwUI view in a scrollview in a presented sheet * feat(MyKSuiteBridgeViewController): Modern sheet presentation * feat(presentUpSaleSheet): Animate a dismiss before presenting * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Shared Env Signed-off-by: Philippe Weidmann <[email protected]> * fix: Lottie needs to be dynamic Signed-off-by: Philippe Weidmann <[email protected]> * test: Remove old test + Stop testing DriveFileManager Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * chore: Bump core Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Bump to 1.0.0 * chore: Tuist update * feat: MykSuite chip (#1421) * feat(FolderTypeTableViewCell): MykSuite chip * feat(NewFolderTypeTableViewController): Present upsale sheet when needed * feat(NewFolderTypeTableViewController): Explicit present call * refactor(FolderTypeTableViewCell): Remove comment * feat(ShareAndRightsViewController): Present upsale on myKSuite * feat(ShareLinkTableViewCell): Display MykSuiteChip * refactor(FolderTypeTableViewCell): Renamed to chipContainerView * feat(FilesHeaderView): Display the trash header view that matches the design * feat(FilesHeaderView): Show trash header view only when needed * feat: Clear color for chip container view * chore(FileListViewController): Force display chip for now * feat(MyKSuiteChip): Proper chip design with correct background color * fix(FilesHeaderView): Correct margin for chip view * fix(FolderTypeTableViewCell): Correct chip constraint * chore(FileListViewController): Better temporary display logic * feat(FilesHeaderView): Present upsale sheet on tap * feat(ShareLinkTableViewCell): Handle extra actions for mykSuite * feat(MyKSuiteBridgeViewController): Modern sheet presentation * feat(presentUpSaleSheet): Animate a dismiss before presenting * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Shared Env Signed-off-by: Philippe Weidmann <[email protected]> * fix: Lottie needs to be dynamic Signed-off-by: Philippe Weidmann <[email protected]> * test: Remove old test + Stop testing DriveFileManager Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * chore: Bump core Signed-off-by: Philippe Weidmann <[email protected]> * feat(FolderTypeTableViewCell): Changed space between title and subtitle to 8pt * feat(FilesHeaderView): Bump margin between title and subtitle to 8pt * feat(myKSuitePlus.logo): Dark mode * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * feat(myKSuitePlus.logo): Dark mode background color * feat(greyBackgroundChipColor): Changed darkmode background color * feat(Drive+Quota): If Quota is not present we do not enforce limitations app side * feat(Drive): Method isFreePack return true when pack is myKSuite * feat(LocalizedFilenameFormatter): Use drive.isFreePack for correctness * chore: Update to latest version os i18n * feat(FileListViewController): Correct check for trash folder * feat(FilesHeaderView): Translations for mykSuite trash header view * refactor: PR self feedback * refactor: Chore typo * feat(ShareAndRightsViewController): Removed force display chip * feat(ShareLinkTableViewCell): Removed force display chip * feat(NewFolderTypeTableViewController): Enable pack check * chore: Clean dead comment * feat(FileListViewController): Enable actual mykSuite logic check * fix: Make the branch build great again * refactor(ShareLinkTableViewCell): Make sure the cell loads great * chore: Update project post rebase to work on ios-features 1.0.0 * chore: Project setup * chore: Remove trash asset and substitute it for delete * feat(FilesHeaderView): Using TextStyle with IKLabel * chore: Remove duplicated color * feat(FilesHeaderView): Using existing color * feat(FloatingPanelActionCollectionViewCell): Chip capability (#1429) * feat(FloatingPanelActionCollectionViewCell): Chip capability * feat: Enable chip for convertToDropbox action * feat: Rework existing limitations (#1428) * feat(MenuViewController): Hide upgrade cell that shows up on top of menu * feat(ShareLinkSettingsViewController): Present upsale sheet instead of store * feat(FileActionsFloatingPanelViewController): Present upsale sheet instead of store * feat(HomeViewController): Present upsale sheet instead of store * feat(NewFolderTypeTableViewController): Present upsale sheet instead of store * feat(FileActionsHelper): Present upsale sheet instead of store --------- Signed-off-by: Philippe Weidmann <[email protected]> Co-authored-by: Philippe Weidmann <[email protected]> * feat: Dropbox quota (#1432) * feat(NewFolderTypeTableViewController): Dropbox quota * fix: Create dropbox navigation fix * feat(FileActionsFloatingPanelViewController): Quota implementation * chore(router): Removed .askToUpSaleIfQuotaReached method * feat: Public share quota, advanced settings chip (#1430) * feat(ShareLinkSettingTableViewCell): Chip displayed in advanced screen * feat(ShareLinkSettingsViewController): Switch to new modal screen * feat(ShareAndRightsViewController): Add quota check and present modal if required * feat(ShareAndRightsViewController): Check shareLinkQuota before performing actions * feat: Share cell state advanced logic quota * feat(MykSuiteRestrictions): Factorized code * feat(ShareAndRightsViewController): Use guard * feat(MykSuiteRestrictions): More factorized code * feat(ShareLinkSettingTableViewCell): Set button insets to zero * feat: MykSuite dashboard (#1419) * chore: Switch to dashboard branch * feat: New account cell in parameters to display MyKSuiteStore view * feat(MyKSuiteStore): Add type to DI * feat(MyKSuiteDashboardViewBridgeController): Reworked presentation * feat(AccountManager): Refresh myKSuiteStore on login * feat(ParameterTableViewController): Grouped cell UI update * chore: Removed iOS 15 conditional code * feat(): Modern sheet presentation for MyKSuiteBridgeViewController * feat(presentUpSaleSheet): Animate a dismiss before presenting * feat(ios-features): Added necessary libraries as a Framework * chore(MyKSuiteDashboardViewBridgeController): Bumped to lattest ios-features API * feat(ParameterTableViewController): Some i18n * chore: PR Feedback * chore: Remove conditional ios version dependent code * feat(ParameterTableViewController): Dynamic sections if mykSuite enabled * fix(ParameterTableViewCell): Proper prepare for reuse implementation * feat(ParameterTableViewController): Inter18n general section * fix: New ios-features build * chore: Bump core-ui * feat(AsyncImageView): A sample swUI view to display account image still requires fine tuning * feat(AccountManager): Call to updateMyKSuite is no longer breaking authentification if broken * fix(ParameterTableViewController): Correct rounded corner on cell * feat(ParameterTableViewCell): Cell has support for other fonts and can display the current mykSuite account * chore: Bump to ios-features 1.0.2 * chore: Branding my kSuite plus with a plus logo not a plus plus * feat(ParameterTableViewController): Custom design table view section * chore: Remove force display of myksuite * feat(AsyncImageView): Loading view with default color * feat: Check for mykSuite availlable for a user * chore: Bump ios-features * refactor(ParameterTableViewController): Better async loading * fix(ParameterTableViewController): Section title is now correct without a mykSuite * chore: Sonar * refactor(ParameterTableViewController): Use a font with correct color directly * refactor(MyKSuiteDashboardViewBridgeController): Simplify constructor * feat(AccountManager): Update mykSuite on updateUser * refactor(ParameterTableViewController): Remove extraneous lazy DI for direct resolution call * refactor(MenuViewController): Remove extraneous import * refactor(MyKSuiteFloatingPanelBridgeController): Instantiate pattern --------- Signed-off-by: Philippe Weidmann <[email protected]> Co-authored-by: Philippe Weidmann <[email protected]>
adrien-coye
added a commit
that referenced
this pull request
Feb 14, 2025
* feat(Drive): Sample quota implementation for testing * feat(DriveInitWith): Added with=quota to drive init route * feat(DriveInitWith): Init with parameter has changed therefore I updated it * feat(Drive): Quota is now non nullable as discussed with backend * feat(Quota): Parsing quota like discussed with API * feat(Quota): Parsing working * feat(Drive+Quota): If Quota is not present we do not enforce limitations app side * feat(Drive): Method isFreePack return true when pack is myKSuite * feat(LocalizedFilenameFormatter): Use drive.isFreePack for correctness * chore: Removed comment * fix: No need for explicit snake case as converted by network stack * refactor: Quota check is public * feat: MyKSuite UI (#1409) * feat: Present a sample SwiftUI View * feat: Force ios-core-ui to mykSuite branch * feat: Tuist project setup with external feature module * chore: Bump coreUI * feat(MyKSuiteFloatingPanelBridgeController): Display SwiftUI code in container view * feat(MyKSuiteFloatingPanelBridgeController): Adjusted margins * feat(MyKSuiteFloatingPanelBridgeController): New kDrive dedicated assets * feat(Drive): Quota is now non nullable as discussed with backend * feat: Bump UI with latest API * feat(AppRouter): New explicit method presentUpSaleSheet * chore(MyKSuiteFloatingPanelBridgeController): Clean code * fix(AppRouter): Animate presentUpSaleSheet method * fix(AppRouter): Animate MyKSuiteFloatingPanelBridgeController prensentation * chore: Switched to ios-features * fix(MCKRouter): Updated test mock * fix(ios-features): Allow the project to build again with the new linked library * chore(AppRouter): Removed iOS 15 conditional code * chore(MyKSuiteFloatingPanelBridgeController): Removed iOS 15 conditional code * fix(Package.swift): Added InfomaniakDI as a Framework to guarantee only one exists at any point * feat: Trying to bridge a SwUI view in a scrollview in a presented sheet * feat(MyKSuiteBridgeViewController): Modern sheet presentation * feat(presentUpSaleSheet): Animate a dismiss before presenting * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Shared Env Signed-off-by: Philippe Weidmann <[email protected]> * fix: Lottie needs to be dynamic Signed-off-by: Philippe Weidmann <[email protected]> * test: Remove old test + Stop testing DriveFileManager Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * chore: Bump core Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Bump to 1.0.0 * chore: Tuist update * feat: MykSuite chip (#1421) * feat(FolderTypeTableViewCell): MykSuite chip * feat(NewFolderTypeTableViewController): Present upsale sheet when needed * feat(NewFolderTypeTableViewController): Explicit present call * refactor(FolderTypeTableViewCell): Remove comment * feat(ShareAndRightsViewController): Present upsale on myKSuite * feat(ShareLinkTableViewCell): Display MykSuiteChip * refactor(FolderTypeTableViewCell): Renamed to chipContainerView * feat(FilesHeaderView): Display the trash header view that matches the design * feat(FilesHeaderView): Show trash header view only when needed * feat: Clear color for chip container view * chore(FileListViewController): Force display chip for now * feat(MyKSuiteChip): Proper chip design with correct background color * fix(FilesHeaderView): Correct margin for chip view * fix(FolderTypeTableViewCell): Correct chip constraint * chore(FileListViewController): Better temporary display logic * feat(FilesHeaderView): Present upsale sheet on tap * feat(ShareLinkTableViewCell): Handle extra actions for mykSuite * feat(MyKSuiteBridgeViewController): Modern sheet presentation * feat(presentUpSaleSheet): Animate a dismiss before presenting * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Shared Env Signed-off-by: Philippe Weidmann <[email protected]> * fix: Lottie needs to be dynamic Signed-off-by: Philippe Weidmann <[email protected]> * test: Remove old test + Stop testing DriveFileManager Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * chore: Bump core Signed-off-by: Philippe Weidmann <[email protected]> * feat(FolderTypeTableViewCell): Changed space between title and subtitle to 8pt * feat(FilesHeaderView): Bump margin between title and subtitle to 8pt * feat(myKSuitePlus.logo): Dark mode * chore: Upgrade tuist + Explicitly declare dependencies Signed-off-by: Philippe Weidmann <[email protected]> * fix: Remove target grouping Signed-off-by: Philippe Weidmann <[email protected]> * test: Update some old tests Signed-off-by: Philippe Weidmann <[email protected]> * feat(ios-features): Added necessary libraries as a Framework * feat(myKSuitePlus.logo): Dark mode background color * feat(greyBackgroundChipColor): Changed darkmode background color * feat(Drive+Quota): If Quota is not present we do not enforce limitations app side * feat(Drive): Method isFreePack return true when pack is myKSuite * feat(LocalizedFilenameFormatter): Use drive.isFreePack for correctness * chore: Update to latest version os i18n * feat(FileListViewController): Correct check for trash folder * feat(FilesHeaderView): Translations for mykSuite trash header view * refactor: PR self feedback * refactor: Chore typo * feat(ShareAndRightsViewController): Removed force display chip * feat(ShareLinkTableViewCell): Removed force display chip * feat(NewFolderTypeTableViewController): Enable pack check * chore: Clean dead comment * feat(FileListViewController): Enable actual mykSuite logic check * fix: Make the branch build great again * refactor(ShareLinkTableViewCell): Make sure the cell loads great * chore: Update project post rebase to work on ios-features 1.0.0 * chore: Project setup * chore: Remove trash asset and substitute it for delete * feat(FilesHeaderView): Using TextStyle with IKLabel * chore: Remove duplicated color * feat(FilesHeaderView): Using existing color * feat(FloatingPanelActionCollectionViewCell): Chip capability (#1429) * feat(FloatingPanelActionCollectionViewCell): Chip capability * feat: Enable chip for convertToDropbox action * feat: Rework existing limitations (#1428) * feat(MenuViewController): Hide upgrade cell that shows up on top of menu * feat(ShareLinkSettingsViewController): Present upsale sheet instead of store * feat(FileActionsFloatingPanelViewController): Present upsale sheet instead of store * feat(HomeViewController): Present upsale sheet instead of store * feat(NewFolderTypeTableViewController): Present upsale sheet instead of store * feat(FileActionsHelper): Present upsale sheet instead of store --------- Signed-off-by: Philippe Weidmann <[email protected]> Co-authored-by: Philippe Weidmann <[email protected]> * feat: Dropbox quota (#1432) * feat(NewFolderTypeTableViewController): Dropbox quota * fix: Create dropbox navigation fix * feat(FileActionsFloatingPanelViewController): Quota implementation * chore(router): Removed .askToUpSaleIfQuotaReached method * feat: Public share quota, advanced settings chip (#1430) * feat(ShareLinkSettingTableViewCell): Chip displayed in advanced screen * feat(ShareLinkSettingsViewController): Switch to new modal screen * feat(ShareAndRightsViewController): Add quota check and present modal if required * feat(ShareAndRightsViewController): Check shareLinkQuota before performing actions * feat: Share cell state advanced logic quota * feat(MykSuiteRestrictions): Factorized code * feat(ShareAndRightsViewController): Use guard * feat(MykSuiteRestrictions): More factorized code * feat(ShareLinkSettingTableViewCell): Set button insets to zero * feat: MykSuite dashboard (#1419) * chore: Switch to dashboard branch * feat: New account cell in parameters to display MyKSuiteStore view * feat(MyKSuiteStore): Add type to DI * feat(MyKSuiteDashboardViewBridgeController): Reworked presentation * feat(AccountManager): Refresh myKSuiteStore on login * feat(ParameterTableViewController): Grouped cell UI update * chore: Removed iOS 15 conditional code * feat(): Modern sheet presentation for MyKSuiteBridgeViewController * feat(presentUpSaleSheet): Animate a dismiss before presenting * feat(ios-features): Added necessary libraries as a Framework * chore(MyKSuiteDashboardViewBridgeController): Bumped to lattest ios-features API * feat(ParameterTableViewController): Some i18n * chore: PR Feedback * chore: Remove conditional ios version dependent code * feat(ParameterTableViewController): Dynamic sections if mykSuite enabled * fix(ParameterTableViewCell): Proper prepare for reuse implementation * feat(ParameterTableViewController): Inter18n general section * fix: New ios-features build * chore: Bump core-ui * feat(AsyncImageView): A sample swUI view to display account image still requires fine tuning * feat(AccountManager): Call to updateMyKSuite is no longer breaking authentification if broken * fix(ParameterTableViewController): Correct rounded corner on cell * feat(ParameterTableViewCell): Cell has support for other fonts and can display the current mykSuite account * chore: Bump to ios-features 1.0.2 * chore: Branding my kSuite plus with a plus logo not a plus plus * feat(ParameterTableViewController): Custom design table view section * chore: Remove force display of myksuite * feat(AsyncImageView): Loading view with default color * feat: Check for mykSuite availlable for a user * chore: Bump ios-features * refactor(ParameterTableViewController): Better async loading * fix(ParameterTableViewController): Section title is now correct without a mykSuite * chore: Sonar * refactor(ParameterTableViewController): Use a font with correct color directly * refactor(MyKSuiteDashboardViewBridgeController): Simplify constructor * feat(AccountManager): Update mykSuite on updateUser * refactor(ParameterTableViewController): Remove extraneous lazy DI for direct resolution call * refactor(MenuViewController): Remove extraneous import * refactor(MyKSuiteFloatingPanelBridgeController): Instantiate pattern --------- Signed-off-by: Philippe Weidmann <[email protected]> Co-authored-by: Philippe Weidmann <[email protected]> * chore(ios-features): Bump to 1.0.4 * fix(ParameterTableViewController): Linter error * fix(upsaleFolderColor): Removed unused parameters --------- Signed-off-by: Philippe Weidmann <[email protected]> Co-authored-by: Philippe Weidmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR #1405
All chips clear :
All chips dark :
