Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: More defensive enum decoding #1420

Merged
merged 7 commits into from
Feb 4, 2025
Merged

fix: More defensive enum decoding #1420

merged 7 commits into from
Feb 4, 2025

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann
fix: Use name instead of id for packs
6fbe063 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Handle unknown packs
ebff77f 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Handle unknown MaintenanceReason
f6ff0c6 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Handle unknown DriveUserRole
5f0bb34 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Handle unknown FileImportStatus
340fd76 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Handle unknown FileSupportedBy
174ba71 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Explicit unknown case decoding
0140d08 
Signed-off-by: Philippe Weidmann <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adrien-coye
adrien-coye reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I want to play with it a bit before giving the final OK.

@adrien-coye adrien-coye added this to the 5.1.1 milestone Feb 4, 2025
adrien-coye
adrien-coye approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test the app, including public share. All good 👍

@adrien-coye adrien-coye merged commit 0735319 into master Feb 4, 2025
6 checks passed
@adrien-coye adrien-coye deleted the fix-unknown-enums branch February 4, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippeWeidmann @adrien-coye