fix: InExtensionRouter availlable in extension mode to prevent crashes #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ambrdctr
approved these changes
Jan 28, 2025
adrien-coye
force-pushed
the
missing-routable-extension
branch
from
4dbbfb1 to
d4a2273
Compare
adrien-coye
force-pushed
the
missing-routable-extension
branch
from
d4a2273 to
11e75c5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like we discussed, trying to move away from the
if EXTENSIONmodel, I try to rely more on the DI framework.Here in extension mode, some code path tries to call the
AppNavigableprotocol.It does not exist currently in extension mode, and crashes.
Having one is more elegant than #ifdef existing code.
I introduced an
InExtensionRouterthat does nothing.