-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add now playing info for video #1324
Conversation
696ce86
to
c92cac3
Compare
915becc
to
5a6c505
Compare
5a6c505
to
b2e12e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only observe .AVPlayerItemDidPlayToEndTime
.
This only set the correct metadata at the end of the track.
Maybe try to also remove MPMediaItemPropertyPlaybackDuration
and MPNowPlayingInfoPropertyElapsedPlaybackTime
because they should be set by the VideoPlayer
ba1c29c
to
0181d06
Compare
There's always the problem that the video title appears for 1 second and then disappears in the notfication. I'm open to an idea! |
1d83e16
to
a4fb80a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check the 1 second and then disappears
asap.
I'll check the "Title jumps glitch" asap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of small remarks regarding the VideoPlayer
.
I don't think your branch can build right now. We usually try to have branches that can build even if the app is broken.
As a "nice to have", we could also set a thumbnail. We already have one, it should be straight forward. |
8e70dee
to
254be1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, it now looks like the VideoPlayer
is decoupled enough. I no longer see AVPlayer
in the view. Thanks for working on this @Matthieu-dgl .
I'll test the PR again later, including the audio player, when the change asked by @PhilippeWeidmann is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We checked the code together, I need to play with files with metadata.
a1b7a5d
to
e8d1f2e
Compare
e8d1f2e
to
8722a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying changes, I'll show you tomorrow a patch to finish the last details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. It looks good to me, I'll ask @PhilippeWeidmann for a final review.
No description provided.