Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not apply last modified date if not downloaded #1299

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Sep 23, 2024

Applying the new revised at date without redownloading the file was wrong.
This could lead to issues where the local cache would believe that it had the latest version but in fact had still the old one with new date applied.

Copy link

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PhilippeWeidmann PhilippeWeidmann merged commit 94294fc into master Sep 23, 2024
4 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix-file-downloading-update branch September 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants