feat: External links #1236
Closed
feat: External links #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
commented
Aug 20, 2024
| @@ -103,6 +103,18 @@ final class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| } | |||
| application.registerForRemoteNotifications() | |||
|
|
|||
| // swiftlint:disable force_try | |||
|
|
||
| accessBlocked = try container.decode(Bool.self, forKey: .accessBlocked) | ||
| } catch { | ||
| // TODO: remove |
feat(Endpoint): Finish the external links endpoint implementation
adrien-coye
commented
Sep 3, 2024
kDrive/AppRouter.swift
Outdated
| driveFileManager: DriveFileManager, | ||
| apiFetcher: PublicShareApiFetcher | ||
| ) { | ||
| // TODO: Present on top of existing views |
There was a problem hiding this comment.
TODO: Navigation
|
|
||
| // TODO: i18n | ||
| let configuration = Configuration(selectAllSupported: false, | ||
| rootTitle: "public share", |
| return | ||
| } | ||
|
|
||
| // Only show loading indicator if we have nothing in cache |
There was a problem hiding this comment.
guess I can remove this one
| @@ -26,6 +26,21 @@ import InfomaniakLogin | |||
| import RealmSwift | |||
| import SwiftRegex | |||
|
|
|||
| // TODO: Move to core | |||
There was a problem hiding this comment.
TODO: move to core, useful when dealing with many DBs
| @@ -28,7 +28,7 @@ public enum RealmSchemaVersion { | |||
| static let upload: UInt64 = 21 | |||
|
|
|||
| /// Current version of the Drive Realm | |||
| static let drive: UInt64 = 11 | |||
| static let drive: UInt64 = 12 | |||
There was a problem hiding this comment.
Had to bump for automatic migration / new entity fields
| @@ -134,6 +134,14 @@ public final class DriveInfosManager: DriveInfosManagerQueryable { | |||
| drive.sharedWithMe = sharedWithMe | |||
| } | |||
|
|
|||
| // TODO: Add a flag that this drive can be cleaned | |||
There was a problem hiding this comment.
TODO: Cleaning strategy for public share's Drive
| @@ -182,6 +182,19 @@ public enum ConvertedType: String, CaseIterable { | |||
| public static let ignoreThumbnailTypes = downloadableTypes | |||
| } | |||
|
|
|||
| /// Minimal data needed to query a PublicShare | |||
| public struct PublicShareProxy { | |||
There was a problem hiding this comment.
Maybe group all "proxy" types ?
adrien-coye
commented
Sep 18, 2024
|
|
||
| public func getMetadata(driveId: Int, shareLinkUid: String) async throws -> PublicShareMetadata { | ||
| let shareLinkInfoUrl = Endpoint.shareLinkInfo(driveId: driveId, shareLinkUid: shareLinkUid).url | ||
| // TODO: Use authenticated token if availlable |
There was a problem hiding this comment.
TODO: Make sure to send token to enable backend to redirect if needed.
adrien-coye
force-pushed
the
externalLinks
branch
from
85f0cc4 to
76bf4e0
Compare
|
|
Superseded by #1304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Feature PR of the external links
Tasks so far:
FileListViewControllerTo do in sister PRs