Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FileProvider #1125

Merged
merged 8 commits into from
Feb 29, 2024
Merged

fix: FileProvider #1125

merged 8 commits into from
Feb 29, 2024

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Feb 27, 2024 •
edited
Loading

Abstract

Some fixes related to the Files.app behaviour:

  • fix: Make sure no Paused Notification is produced by the FileProvider.
  • fix: Removed a race condition while registering a FileProviderDomain.
  • fix: Explicitly signal FileProvider when it is updated.

Also improved the situation regarding:

  • chore: Sentry tracking with a dedicated Log.driveInfosManager() channel.
  • refactor: Split the DriveInfosManager's FileProvider related code.

@adrien-coye adrien-coye added this to the 4.4.2 milestone Feb 27, 2024
@adrien-coye adrien-coye marked this pull request as draft February 27, 2024 16:21
adrien-coye
adrien-coye commented Feb 28, 2024
View reviewed changes
@adrien-coye
feat: Signal Files.app on FileProviderDomain change
ef191a9 
refactor: Split DriveInfoManager + FileProvider
@adrien-coye
fix: Reimplementation of the diffing algorithm works
de6e615 
refactor: Split some more DriveInfosManager+FileProvider
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adrien-coye adrien-coye marked this pull request as ready for review February 28, 2024 13:16
@PhilippeWeidmann
Copy link
Member

Did some quick tests didn't find anything. LGTM 👍

@PhilippeWeidmann PhilippeWeidmann merged commit 9b9e02f into master Feb 29, 2024
4 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fileManagerAccounts branch February 29, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@adrien-coye @PhilippeWeidmann