fix: Unable to do a transaction with a frozen object #1110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
fixTransaction
branch
from
21c9a3d to
23b4500
Compare
adrien-coye
force-pushed
the
fixTransaction
branch
from
23b4500 to
de6d461
Compare
|
adrien-coye
commented
Feb 9, 2024
| @@ -40,10 +40,12 @@ class InMemoryFileListViewModel: FileListViewModel { | |||
| } | |||
|
|
|||
| super.init(configuration: configuration, driveFileManager: driveFileManager, currentDirectory: currentDirectory) | |||
|
|
|||
| guard let liveDirectory = try? currentDirectory.thaw() else { return } | |||
There was a problem hiding this comment.
This does not fix anything. Sometimes we have a detached object and it works, sometimes we have a frozen one.
We probably should .detach all the time and it should work.
adrien-coye
commented
Feb 9, 2024
|
Supper seeded by #1118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.