fix: Prevent refetching PHAsset #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Weidmann <[email protected]>
|
Let me test it out before I approve it. |
|
So I did double-check, "could we simply use |
adrien-coye
reviewed
Jan 8, 2024
kDriveCore/Data/UploadQueue/Operation/UploadOperation+PHAsset.swift
Outdated
Show resolved
Hide resolved
|
adrien-coye
approved these changes
Jan 9, 2024
|
Got validation in DM, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a new file corresponding to the PHAsset is fetched every time an upload session is restarted.
Because of how we get the PHAsset the new file has a new file and is effectively duplicated with a new name. Old files are never cleared because we only clear the new file upon upload completion.