Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Menu v3 #1022

Merged
merged 64 commits into from
Jan 30, 2024
Merged

feat: Menu v3 #1022

merged 64 commits into from
Jan 30, 2024

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Sep 18, 2023 •
edited
Loading

Depends on #1023

@PhilippeWeidmann PhilippeWeidmann changed the base branch from master to api-v3 September 18, 2023 12:57
@adrien-coye adrien-coye added this to the 4.3.5 milestone Oct 24, 2023
@adrien-coye adrien-coye modified the milestones: 4.3.5, 4.3.6 Nov 2, 2023
@PhilippeWeidmann PhilippeWeidmann force-pushed the menu-v3 branch 2 times, most recently from 118ddbb to 5d08352 Compare November 3, 2023 13:37
@adrien-coye adrien-coye modified the milestones: 4.3.6, 4.3.7 Nov 21, 2023
@adrien-coye adrien-coye modified the milestones: 4.3.7, APIV3 Nov 29, 2023
@PhilippeWeidmann PhilippeWeidmann force-pushed the api-v3 branch 2 times, most recently from 2c7e766 to b6dd29d Compare December 6, 2023 06:17
@PhilippeWeidmann PhilippeWeidmann force-pushed the menu-v3 branch 2 times, most recently from 60b157a to e0a777c Compare December 15, 2023 09:31
@adrien-coye adrien-coye changed the base branch from api-v3 to releaseAPIV3 December 18, 2023 12:20
@PhilippeWeidmann PhilippeWeidmann force-pushed the menu-v3 branch 2 times, most recently from 321d14f to b044ea0 Compare December 20, 2023 08:29
@PhilippeWeidmann
feat: Upload API V3
073e391 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Migrate necessary endpoints to V3
6752327 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored paging WIP
8a82799 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored file list
5cf97d7 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored MyShares
1d97c12 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored last modifications
3c1677d 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored search + gallery
3c27209 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Cursored home
cd699cf 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: To compile trash file provider
9943948 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Basic listing with cursor
e9a8550 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Rename is on api V2
4b4db18 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Listing file actions
a71f5d8 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
refactor: Renamed listingCursor to advancedListingCursor
f55b79d 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Keep lastCursor for children
05528eb 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Only force refresh first call
71a2e8e 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
feat: Use filesSupportedBy
35fa3c4 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Only handle latest action
e8cdf38 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Use same code for rename and update actions
2cbe96b 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
fix: Observe supportedBy instead of hasThumbnail
c3afec6 
Signed-off-by: Philippe Weidmann <[email protected]>
@PhilippeWeidmann
Merge branch 'api-v3' into menu-v3
538a428 
Signed-off-by: Philippe Weidmann <[email protected]>

# Conflicts:
#	.package.resolved
#	Project.swift
#	kDriveCore/Data/Models/File.swift
@PhilippeWeidmann
Merge branch 'api-v3' into menu-v3
da028d5 
Signed-off-by: Philippe Weidmann <[email protected]>

# Conflicts:
#	.package.resolved
#	kDriveCore/Data/Models/File.swift
@PhilippeWeidmann
fix: Remove uselss localizedName
135665c 
Signed-off-by: Philippe Weidmann <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review January 29, 2024 14:56
@PhilippeWeidmann PhilippeWeidmann requested a review from a team as a code owner January 29, 2024 14:56
@PhilippeWeidmann PhilippeWeidmann changed the base branch from api-v3 to releaseAPIV3 January 29, 2024 14:57
@PhilippeWeidmann PhilippeWeidmann changed the base branch from releaseAPIV3 to api-v3 January 29, 2024 14:57
adrien-coye
adrien-coye reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor remarks. All good.

adrien-coye
adrien-coye approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback.

Base automatically changed from api-v3 to releaseAPIV3 January 30, 2024 13:29
@PhilippeWeidmann PhilippeWeidmann merged commit d04941a into releaseAPIV3 Jan 30, 2024
1 of 9 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the menu-v3 branch January 30, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippeWeidmann @adrien-coye