fix: Clean the code according to review

Infomaniak · Feb 19, 2025 · b135885 · b135885
1 parent f3be8e2
commit b135885
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/kDrive/UI/Controller/Home/RootMenuHeaderView.swift b/kDrive/UI/Controller/Home/RootMenuHeaderView.swift
@@ -92,7 +92,6 @@ class RootMenuHeaderView: UICollectionReusableView {
     }
 
     @objc func reloadWifiView(_ notification: Notification) {
-        print("Call observeNetworkChange")
         updateWifiView()
     }
 

diff --git a/kDrive/UI/Controller/Menu/PhotoSyncSettingsViewController.swift b/kDrive/UI/Controller/Menu/PhotoSyncSettingsViewController.swift
@@ -550,11 +550,7 @@ extension PhotoSyncSettingsViewController: PhotoSyncSettingsTableViewCellDelegat
 extension PhotoSyncSettingsViewController: WifiSyncSettingsDelegate {
     func didSelectSyncMode(_ mode: SyncMode) {
         liveNewSyncSettings.wifiSync = mode
-        if mode == .onlyWifi {
-            UserDefaults.shared.isWifiOnly = true
-        } else {
-            UserDefaults.shared.isWifiOnly = false
-        }
+        UserDefaults.shared.isWifiOnly = (mode == .onlyWifi)
         updateSaveButtonState()
         tableView.reloadRows(
             at: [IndexPath(row: PhotoSyncSettingsRows.wifiSync.rawValue, section: PhotoSyncSection.syncSettings.rawValue)],

diff --git a/kDriveCore/Data/UploadQueue/Operation/UploadOperation+PHAsset.swift b/kDriveCore/Data/UploadQueue/Operation/UploadOperation+PHAsset.swift
@@ -73,8 +73,8 @@ extension UploadOperation {
             return
         }
 
-        uploadQueue.cancelRunningOperations()
         uploadQueue.suspendAllOperations()
+        uploadQueue.cancelRunningOperations()
         throw ErrorDomain.uploadOverDataRestrictedError
     }
 }
diff --git a/kDriveCore/Utils/DriveUserDefaults+Extension.swift b/kDriveCore/Utils/DriveUserDefaults+Extension.swift
@@ -49,7 +49,7 @@ extension UserDefaults.Keys {
     static let selectedHomeIndex = UserDefaults.Keys(rawValue: "selectedHomeIndex")
     static let fpStorageVersion = UserDefaults.Keys(rawValue: "fpStorageVersion")
     static let importPhotoFormat = UserDefaults.Keys(rawValue: "importPhotoFormat")
-    static let syncOfflineMode = UserDefaults.Keys(rawValue: "syncOfflineMod")
+    static let syncOfflineMode = UserDefaults.Keys(rawValue: "syncOfflineMode")
 }
 
 public extension UserDefaults {
-Original file line number
+Diff line change
@@ Expand Up / @@ -92,7 +92,6 @@ class RootMenuHeaderView: UICollectionReusableView { @@
         }
         @objc func reloadWifiView(_ notification: Notification) {
-            print("Call observeNetworkChange")
             updateWifiView()
         }
@@ Expand Down @@