fix: Explicit unknown case decoding

Signed-off-by: Philippe Weidmann <[email protected]>

kDrive/UI/View/Files/FileDetail/FileDetailActivityTableViewCell.swift

@@ -133,7 +133,7 @@ class FileDetailActivityTableViewCell: InsetTableViewCell {
             localizedKey = "fileDetailsActivityFileColorUpdate"
         case .fileColorDelete:
             localizedKey = "fileDetailsActivityFileColorDelete"
-        case .none:
+        case .unknown:
             localizedKey = "fileActivityUnknown"
         }
         detailLabel.text = localizedKey.localized

kDriveCore/Data/Models/Drive/Drive.swift

@@ -142,11 +142,7 @@ public final class Drive: Object, Codable {
     }
 
     public var isFreePack: Bool {
-        guard let packId = pack.drivePackId else {
-            return false
-        }
-
-        return packId == .free
+        return pack.drivePackId == .free
     }
 
     public var isInTechnicalMaintenance: Bool {

kDriveCore/Data/Models/Drive/DrivePack.swift

@@ -30,6 +30,10 @@ public enum DrivePackId: String {
     case myKSuite = "my_ksuite"
     case myKSuitePlus = "my_ksuite_plus"
     case unknown
+
+    public init(apiRawValue: String) {
+        self = .init(rawValue: apiRawValue) ?? .unknown
+    }
 }
 
 public class DrivePack: EmbeddedObject, Codable {
@@ -42,8 +46,8 @@ public class DrivePack: EmbeddedObject, Codable {
     }
 
     /// Convenience enum bridge
-    public var drivePackId: DrivePackId? {
-        DrivePackId(rawValue: name)
+    public var drivePackId: DrivePackId {
+        DrivePackId(apiRawValue: name)
     }
 
     enum CodingKeys: String, CodingKey {

kDriveCore/Data/Models/File.swift

@@ -181,6 +181,10 @@ public enum ConvertedType: String, CaseIterable {
     public static let ignoreThumbnailTypes = downloadableTypes
     /// Documents that can be previewed by the OS but not necessarily handled by OnlyOffice (eg. .pages)
     public static let documentTypes: Set<ConvertedType> = [.presentation, .spreadsheet, .text]
+
+    public init(apiRawValue: String) {
+        self = .init(rawValue: apiRawValue) ?? .unknown
+    }
 }
 
 /// Minimal data needed to query a PublicShare
@@ -688,7 +692,7 @@ public final class File: Object, Codable {
         } else if isBookmark {
             return .url
         } else {
-            return ConvertedType(rawValue: extensionType ?? "") ?? .unknown
+            return ConvertedType(apiRawValue: extensionType ?? "")
         }
     }
 

kDriveCore/Data/Models/FileActivity.swift

@@ -58,6 +58,7 @@ public enum FileActivityType: String, Codable, CaseIterable {
     case collaborativeUserDelete = "collaborative_user_delete"
     case fileColorUpdate = "file_color_update"
     case fileColorDelete = "file_color_delete"
+    case unknown
 
     public static let displayedFileActivities: [FileActivityType] = [
         .fileCreate,
@@ -85,6 +86,10 @@ public enum FileActivityType: String, Codable, CaseIterable {
         .fileColorUpdate,
         .fileColorDelete
     ]
+
+    public init(apiRawValue: String) {
+        self = .init(rawValue: apiRawValue) ?? .unknown
+    }
 }
 
 public class FileActivity: Object, Decodable {
@@ -109,8 +114,8 @@ public class FileActivity: Object, Decodable {
     public var mergedFileActivities: [FileActivity] = []
 
     /// Activity type
-    public var action: FileActivityType? {
-        return FileActivityType(rawValue: rawAction)
+    public var action: FileActivityType {
+        return FileActivityType(apiRawValue: rawAction)
     }
 
     public var user: DriveUser? {