feat: Make time picker dialog reusable #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyDL-Infomaniak
requested changes
Feb 19, 2025
app/src/main/java/com/infomaniak/mail/ui/alertDialogs/SelectDateAndTimeDialog.kt
Outdated
Show resolved
Hide resolved
tevincent
requested changes
Feb 20, 2025
...rc/main/java/com/infomaniak/mail/ui/alertDialogs/SelectDateAndTimeForScheduledDraftDialog.kt
Show resolved
Hide resolved
LunarX
force-pushed
the
make-time-picker-dialog-reusable
branch
from
0dfafca to
d968ce7
Compare
tevincent
approved these changes
Feb 20, 2025
TommyDL-Infomaniak
approved these changes
Feb 20, 2025
…ature I've split in two classes the logic that's specific to the schedule dialog and the logic that's common and generic to a reusable time picker dialog
…the abstract class
…electDateAndTimeDialog
LunarX
force-pushed
the
make-time-picker-dialog-reusable
branch
from
d968ce7 to
e023f35
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll need to reuse this custom time picker dialog for the snooze feature so I made it reusable.
In this PR I've split in two classes the logic that's specific to the schedule dialog and the logic that's common and generic to a reusable time picker dialog