Prevent showing and hiding progress crashes by using showProgressCatching() and hideProgressCatching() #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevincent
approved these changes
Jun 27, 2024
…ress This happens quite often even though it seems that we try and do everything to avoid it
…ress The same way we did it for showProgressCatching()
LunarX
force-pushed
the
show-progress-catching
branch
from
fecd52b to
9106406
Compare
|
This PR/issue depends on:
|
sirambd
approved these changes
Jun 27, 2024
LunarX
force-pushed
the
show-progress-catching
branch
from
9106406 to
54e3cbf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The methods showProgress() and hideProgress() keep crashing on many occasions despite our best efforts to do things correctly. This PR uses showProgressCatching() and showProgressCatching() to avoid crashing
Depends on Infomaniak/android-core#201