Add Bimi feature #1913
Merged
Add Bimi feature #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasBourdin88
added
the
feature
github-actions
bot
added
dependent
|
This PR/issue depends on:
|
KevinBoulongne
requested changes
Jun 17, 2024
app/src/main/java/com/infomaniak/mail/ui/main/AvatarNameEmailView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/DetailedRecipientAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadFragment.kt
Outdated
Show resolved
Hide resolved
NicolasBourdin88
force-pushed
the
bimi
branch
2 times, most recently
from
426a859 to
357afaf
Compare
KevinBoulongne
requested changes
Jun 17, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadAdapter.kt
Outdated
Show resolved
Hide resolved
NicolasBourdin88
force-pushed
the
bimi
branch
2 times, most recently
from
caccf9c to
0ae738f
Compare
tevincent
requested changes
Jun 18, 2024
app/src/main/java/com/infomaniak/mail/data/cache/RealmDatabase.kt
Outdated
Show resolved
Hide resolved
tevincent
approved these changes
Jun 18, 2024
|
@KevinBoulongne can you check again if everything is good for you? |
KevinBoulongne
requested changes
Jun 25, 2024
app/src/main/java/com/infomaniak/mail/ui/main/thread/DetailedRecipientAdapter.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
approved these changes
Jun 25, 2024
Change emplacement so we don't import the coil svg lib everywhere, only in mail
Update core
Apply suggestion from code review
…ecipientAdapter.kt
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be careful about when they will add format PNG to the route, normally it will not affect our route because they (IOS) will just have to add "?format=png" at the end of the call.
Depends on Infomaniak/android-core#179