Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log NetworkException in Sentry #1853

Merged
merged 2 commits into from
May 16, 2024
Merged

Don't log NetworkException in Sentry #1853

merged 2 commits into from
May 16, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented May 14, 2024 •
edited
Loading

We don't want to send Sentry about NetworkException.
So we make sure that when we send a Sentry about an Exception, it's not a NetworkException.

@KevinBoulongne KevinBoulongne added the optimization Improve the performance or efficiency of the code label May 14, 2024
@KevinBoulongne KevinBoulongne requested a review from a team May 14, 2024 11:16
LunarX
LunarX requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could create a Sentry.captureNonNetworkException() method so when autocompleting while capturing an exception we can think about using this new method and this would automatically filter out all the NetworkException

@KevinBoulongne KevinBoulongne force-pushed the networkException-sentry branch from 6905a6c to f7cb149 Compare May 15, 2024 07:56
@KevinBoulongne KevinBoulongne requested a review from LunarX May 15, 2024 07:57
@KevinBoulongne KevinBoulongne changed the title Remove Sentry about NetworkException Don't log NetworkException in Sentry May 15, 2024
@KevinBoulongne KevinBoulongne force-pushed the networkException-sentry branch 2 times, most recently from 6c140a6 to 837a370 Compare May 16, 2024 06:11
@KevinBoulongne KevinBoulongne force-pushed the networkException-sentry branch from 837a370 to df26b95 Compare May 16, 2024 07:17
@KevinBoulongne KevinBoulongne force-pushed the networkException-sentry branch from df26b95 to df56e57 Compare May 16, 2024 07:20
@KevinBoulongne KevinBoulongne requested review from a team and LunarX and removed request for LunarX May 16, 2024 07:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne added the quick A pull request consisting of a few lines label May 16, 2024
@LunarX LunarX merged commit 134bc09 into master May 16, 2024
5 checks passed
@LunarX LunarX deleted the networkException-sentry branch May 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

@FabianDevel FabianDevel FabianDevel approved these changes

Assignees

@KevinBoulongne KevinBoulongne

Labels
optimization Improve the performance or efficiency of the code quick A pull request consisting of a few lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @LunarX @FabianDevel