Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change values() to entries after kotlin 1.9 #1620

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Change values() to entries after kotlin 1.9 #1620

merged 1 commit into from
Jan 4, 2024

Conversation

FabianDevel
Copy link
Contributor

@FabianDevel FabianDevel commented Jan 3, 2024 •
edited
Loading

Depends on Infomaniak/android-core#115
Depends on #1622

@FabianDevel FabianDevel added the enhancement Improve or expand upon an existing feature label Jan 3, 2024
@FabianDevel FabianDevel requested a review from a team as a code owner January 3, 2024 15:46
@github-actions github-actions bot added the dependent This MR depends on another PR label Jan 3, 2024
@FabianDevel FabianDevel force-pushed the Change-values()-to-entries branch from a4c54e3 to b02d39a Compare January 3, 2024 15:58
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jan 3, 2024
@FabianDevel FabianDevel marked this pull request as draft January 3, 2024 16:01
@FabianDevel FabianDevel marked this pull request as ready for review January 3, 2024 16:10
@github-actions github-actions bot added the dependent This MR depends on another PR label Jan 3, 2024
LunarX
LunarX requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your branch needs to target #1622 because right now it doesn't build

@FabianDevel FabianDevel force-pushed the Change-values()-to-entries branch from b02d39a to 1e58782 Compare January 4, 2024 08:37
@FabianDevel FabianDevel changed the base branch from master to migrate-room-to-ksp January 4, 2024 08:38
@FabianDevel FabianDevel requested a review from LunarX January 4, 2024 08:38
Base automatically changed from migrate-room-to-ksp to master January 4, 2024 13:59
@github-actions github-actions bot removed the dependent This MR depends on another PR label Jan 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

This PR/issue depends on:

@FabianDevel FabianDevel force-pushed the Change-values()-to-entries branch from 1e58782 to 9b6e150 Compare January 4, 2024 14:01
@FabianDevel FabianDevel force-pushed the Change-values()-to-entries branch from 9b6e150 to 68d6038 Compare January 4, 2024 14:16
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LunarX LunarX merged commit 41015d1 into master Jan 4, 2024
3 checks passed
@LunarX LunarX deleted the Change-values()-to-entries branch January 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirambd sirambd sirambd approved these changes

@LunarX LunarX LunarX approved these changes

Assignees

@FabianDevel FabianDevel

Labels
enhancement Improve or expand upon an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabianDevel @sirambd @LunarX