fix: Delete Attachment in Realm when we delete it while writing a mail (

#2149)
Infomaniak · Feb 10, 2025 · c8ed034 · c8ed034
2 parents e19401e + 73c1fb9
commit c8ed034
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 15 deletions.
diff --git a/app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt b/app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt
@@ -780,13 +780,22 @@ class NewMessageViewModel @Inject constructor(
         if (recipient.isDisplayedAsExternal) appContext.trackExternalEvent("deleteRecipient")
     }
 
-    fun deleteAttachment(position: Int) = runCatching {
-        val attachments = attachmentsLiveData.valueOrEmpty().toMutableList()
-        val attachment = attachments[position]
-        attachment.getUploadLocalFile()?.delete()
-        LocalStorageUtils.deleteAttachmentUploadDir(appContext, draftLocalUuid!!, attachment.localUuid)
-        attachments.removeAt(position)
-        attachmentsLiveData.value = attachments
+    fun deleteAttachment(position: Int) = viewModelScope.launch(ioCoroutineContext) {
+        runCatching {
+            val attachments = attachmentsLiveData.valueOrEmpty().toMutableList()
+            val attachment = attachments[position]
+            attachment.getUploadLocalFile()?.delete()
+            LocalStorageUtils.deleteAttachmentUploadDir(appContext, draftLocalUuid!!, attachment.localUuid)
+
+            mailboxContentRealm().write {
+                draftController.updateDraft(draftLocalUuid!!, realm = this) {
+                    it.attachments.findSpecificAttachment(attachment)?.let(::delete)
+                }
+            }
+
+            attachments.removeAt(position)
+            attachmentsLiveData.postValue(attachments)
+        }
     }
 
     fun updateIsSendingAllowed(

diff --git a/app/src/main/java/com/infomaniak/mail/utils/extensions/AttachmentExtensions.kt b/app/src/main/java/com/infomaniak/mail/utils/extensions/AttachmentExtensions.kt
@@ -208,14 +208,7 @@ object AttachmentExtensions {
         }
     }
 
-    fun List<Attachment>.findSpecificAttachment(attachment: Attachment) = this
-        .filter { it.localUuid == attachment.localUuid }
-        .also {
-            // TODO: If this Sentry never triggers, remove it and replace the
-            //  `filter { … }.also { … }.firstOrNull()` with `singleOrNull { … }`
-            if (it.count() > 1) Sentry.captureMessage("Found several Attachments with the same localUuid")
-        }
-        .firstOrNull()
+    fun List<Attachment>.findSpecificAttachment(attachment: Attachment) = singleOrNull { it.localUuid == attachment.localUuid }
 
     enum class AttachmentIntentType {
         OPEN_WITH,