fix: The Mediastore deletion request may generate a NullPointerException if the limit exceeds 10_000 uris. #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sirambd
commented
Feb 19, 2025
•
sirambd
commented
- Make a chunk of 5000 per uris when we exceed, because even before 10_000 it happens that the query does not work.
- Avoid multiple dialogs when requesting media deletion
- Make sure that the request is made only in Start rather than in summary, which didn't make much sense.
KevinBoulongne
requested changes
Feb 20, 2025
sirambd
force-pushed
the
fix-mediastore-delete-request
branch
from
77839e1 to
1065416
Compare
sirambd
force-pushed
the
fix-mediastore-delete-request
branch
from
0bc8bb6 to
d5941a7
Compare
tevincent
approved these changes
Feb 24, 2025
KevinBoulongne
requested changes
Feb 24, 2025
app/src/main/java/com/infomaniak/drive/data/models/UploadFile.kt
Outdated
Show resolved
Hide resolved
sirambd
force-pushed
the
fix-mediastore-delete-request
branch
from
a538d7a to
78f744d
Compare
KevinBoulongne
approved these changes
Feb 24, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.