Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow keyboard navigation #1480

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Allow keyboard navigation #1480

wants to merge 6 commits into from

Conversation

NicolasBourdin88
Copy link
Contributor

Remove all keyboard traps and ensure that all interactive elements are focusable.

@NicolasBourdin88 NicolasBourdin88 added the feature A new functionality is added to the product label Nov 1, 2024
@NicolasBourdin88 NicolasBourdin88 self-assigned this Nov 1, 2024
@NicolasBourdin88 NicolasBourdin88 added the rebase Add this label to rebase the PR label Nov 19, 2024
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Nov 19, 2024
@NicolasBourdin88 NicolasBourdin88 requested a review from a team November 20, 2024 12:31
@NicolasBourdin88 NicolasBourdin88 changed the title Allow keyboard navigation feat: Allow keyboard navigation Dec 17, 2024
@NicolasBourdin88 NicolasBourdin88 added the rebase Add this label to rebase the PR label Jan 30, 2025
@github-actions github-actions bot removed the rebase Add this label to rebase the PR label Jan 30, 2025
@LunarX
Copy link
Contributor

LunarX commented Feb 20, 2025 •
edited
Loading

While navigating with the keyboard in order to activate the photo sync I had to select a folder. After a creating a new empty folder, I could not validate my folder choice with the keyboard, it seems to be focusing the background somehow instead. Am I missing an input?

image

@LunarX
Copy link
Contributor

LunarX commented Feb 20, 2025

Also when picking what folders of my phone to sync, my choice isn't taken into account when leaving the screen using the keyboard to click on the top left cross. I don't even get how this is possible

@LunarX
Copy link
Contributor

LunarX commented Feb 20, 2025

Also when previewing a file in the view pager, I can't seem to reach to top toolbar with the keyboard

@LunarX
Copy link
Contributor

LunarX commented Feb 20, 2025

When navigating inside folders and then navigating back up a level, the folder I just left is not selected anymore. Do you think it would be possible to select again the folder "we came from"?

LunarX
LunarX requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left the comments about the most important behaviors I've seen

@NicolasBourdin88
Copy link
Contributor Author

When navigating inside folders and then navigating back up a level, the folder I just left is not selected anymore. Do you think it would be possible to select again the folder "we came from"?

Summary:
After looking into a solution, it seems challenging because the approach we're using in Infomaniak Mail doesn’t work with RecyclerView due to ID and tag recomposition.

LunarX
LunarX requested changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the toolbar of the fragment_ment_gallery is not accessible

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX approved these changes

Assignees

@NicolasBourdin88 NicolasBourdin88

Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasBourdin88 @LunarX